Re: [PATCH v20 02/20] mm/memcg: bail early from swap accounting if memcg disabled

Alex Shi
2020-10-30T02:30:05Z

在 2020/10/29 下午9:46, Johannes Weiner 写道:
>> ? release_pages+0x1ae/0x410
>> shmem_alloc_and_acct_page+0x77/0x1c0
>> shmem_getpage_gfp+0x162/0x910
>> shmem_fault+0x74/0x210
>> ? filemap_map_pages+0x29c/0x410
>> __do_fault+0x37/0x190
>> handle_mm_fault+0x120a/0x1770
>> exc_page_fault+0x251/0x450
>> ? asm_exc_page_fault+0x8/0x30
>> asm_exc_page_fault+0x1e/0x30
>>
>> Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
>> Reviewed-by: Roman Gushchin <guro@fb.com>
>> Acked-by: Michal Hocko <mhocko@suse.com>
>> Acked-by: Hugh Dickins <hughd@google.com>
>> Cc: Johannes Weiner <hannes@cmpxchg.org>
>> Cc: Michal Hocko <mhocko@kernel.org>
>> Cc: Vladimir Davydov <vdavydov.dev@gmail.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: cgroups@vger.kernel.org
>> Cc: linux-mm@kvack.org
>> Cc: linux-kernel@vger.kernel.org
> Acked-by: Johannes Weiner <hannes@cmpxchg.org>
>
> This should go in before the previous patch that adds the WARN for it.

Right, but than the long ops may not weird. Should I remove the ops and resend the whole patchset?

Which way is convenient for you?

Thanks
Alex