Re: [PATCH v20 00/20] per memcg lru lock

Alex Shi
2020-11-05T05:08:00Z

在 2020/11/5 上午12:59, Johannes Weiner 写道:
> On Wed, Nov 04, 2020 at 07:55:39PM +0800, Alex Shi wrote:
>> @@ -1380,6 +1383,14 @@ struct lruvec *mem_cgroup_page_lruvec(struct page *page, struct pglist_data *pgd
>> return lruvec;
>> }
>>
>> +/**
>> + * lock_page_lruvec - return lruvec for the locked page.
>
> I would say "lock and return the lruvec for a given page"
>
>> + * @page: the page
>> + *
>> + * This series functions should be used in either conditions:
>> + * PageLRU is cleared or unset
>> + * or, page->_refcount is zero
>
> or page is locked
>
> The other changes look good to me, thanks!
>

Thanks a lot for both comments!
I will pick them and sent out in v21.

Thanks!
Alex