From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Loic Tourlonias <loic.tourlonias.lkml@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: remove unused code
Date: Mon, 8 Oct 2018 09:57:57 +0200 [thread overview]
Message-ID: <ef326b3d-1d65-3fdb-b18e-428236874335@embeddedor.com> (raw)
In-Reply-To: <20181008073336.17362-1-loic.tourlonias.lkml@gmail.com>
Hi,
On 10/8/18 9:33 AM, Loic Tourlonias wrote:
> Remove useless code inside if_0 endif
>
> Signed-off-by: Loic Tourlonias <loic.tourlonias.lkml@gmail.com>
> ---
> drivers/staging/emxx_udc/emxx_udc.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/emxx_udc/emxx_udc.h b/drivers/staging/emxx_udc/emxx_udc.h
> index 8337e38c238a..78fa60192a14 100644
> --- a/drivers/staging/emxx_udc/emxx_udc.h
> +++ b/drivers/staging/emxx_udc/emxx_udc.h
> @@ -10,10 +10,6 @@
>
> /*---------------------------------------------------------------------------*/
> /*----------------- Default undef */
> -#if 0
> -#define DEBUG
> -#define UDC_DEBUG_DUMP
> -#endif
>
Don't remove that code. This is a common practice for debugging.
Whenever the developer needs to debug something in the whole driver, he/she
just has to change that #if 0 to #if 1 and then all the code under DEBUG
and UDC_DEBUG_DUMP will be enabled.
Notice that UDC_DEBUG_DUMP is being used in drivers/staging/emxx_udc/emxx_udc.c
Thanks
--
Gustavo
next prev parent reply other threads:[~2018-10-08 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 7:33 [PATCH] staging: emxx_udc: remove unused code Loic Tourlonias
2018-10-08 7:57 ` Gustavo A. R. Silva [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-02 2:17 [PATCH] staging: emxx_udc: Remove " John B. Wyatt IV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef326b3d-1d65-3fdb-b18e-428236874335@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.tourlonias.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox