* [PATCH next] drm/amdgpu: unlock on error in amdgpu_userq_create()
@ 2025-07-15 22:58 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2025-07-15 22:58 UTC (permalink / raw)
To: Sunil Khatri
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Shashank Sharma, Arvind Yadav, Arunpravin Paneer Selvam, amd-gfx,
dri-devel, linux-kernel, kernel-janitors
We need to drop a couple locks before returning if the kasprintf() fails.
Fixes: c03ea34cbf88 ("drm/amdgpu: add support of debugfs for mqd information")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
index 492f1089316f..c3ace8030530 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
@@ -521,8 +521,10 @@ amdgpu_userq_create(struct drm_file *filp, union drm_amdgpu_userq *args)
}
queue_name = kasprintf(GFP_KERNEL, "queue-%d", qid);
- if (!queue_name)
- return -ENOMEM;
+ if (!queue_name) {
+ r = -ENOMEM;
+ goto unlock;
+ }
#if defined(CONFIG_DEBUG_FS)
/* Queue dentry per client to hold MQD information */
--
2.47.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2025-07-15 22:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 22:58 [PATCH next] drm/amdgpu: unlock on error in amdgpu_userq_create() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).