From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Philipp Zabel <p.zabel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Subject: Re: [PATCH] ARC: reset: remove the misleading v1 suffix all over
Date: Wed, 27 Sep 2017 11:07:34 -0700 [thread overview]
Message-ID: <ef62e890-e35a-e6fd-d8a4-9c2fbeaf8b9e@synopsys.com> (raw)
In-Reply-To: <1505385897.10100.4.camel@pengutronix.de>
Hi Philipp,
On 09/14/2017 03:44 AM, Philipp Zabel wrote:
> On Mon, 2017-09-11 at 09:33 -0700, Vineet Gupta wrote:
>> On 09/11/2017 03:28 AM, Philipp Zabel wrote:
>>> Hi Vineet,
>>>
>>> [added Eugeniy to Cc]
>>>
>>> On Thu, 2017-08-31 at 11:06 -0700, Vineet Gupta wrote:
>>>> There is no plan yet to do a v2 board. And even if we were to do
>>>> it
>>>> only some IPs would actually change, so it be best to add suffixes
>>>> at
>>>> that point, not now !
>>>>
>>>> Cc: Philipp Zabel <p.zabel@pengutronix.de>
>>>> Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
>>>> ---
>>>> P.S. Philip, if you and Eugeniy are OK, can this be please
>>>> squashed
>>>> with his original patch since it has not yet been merged etc.
>>>
>>> This had been merged into arm-soc already, and by now is merged into
>>> mainline. We could try to queue this as a fix for 4.14.
>>
>> OK - do you want a respin ?
>>
>>>
>>> [...]
>>>> --- a/drivers/reset/Kconfig
>>>> +++ b/drivers/reset/Kconfig
>>>> @@ -34,11 +34,11 @@ config RESET_BERLIN
>>>> help
>>>> This enables the reset controller driver for Marvell
>>>> Berlin
>>>> SoCs.
>>>>
>>>> -config RESET_HSDK_V1
>>>> - bool "HSDK v1 Reset Driver"
>>>> +config RESET_SNPS_HSDK
>>>
>>> I suggest to drop the _SNPS part, we don't do it for the other
>>> drivers
>>> either, and so far I'm not afraid of conflicts with other reset
>>> controllers that may be called HSDK.
>>
>> It was not so much about namespace conflict but calling out that this
>> is SNPS part !
>> But I'm fine with what you suggest, since the updated menu string does
>> have it.
>
> Ok, thanks. No need for a respin, I can fix it up as I apply it.
How/when do you plan to get his merged. Perhaps I can work with a non-mutable
branch from you to base my changes off of ?
Thx,
-Vineet
next prev parent reply other threads:[~2017-09-27 18:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-31 18:06 [PATCH] ARC: reset: remove the misleading v1 suffix all over Vineet Gupta
2017-09-11 10:28 ` Philipp Zabel
2017-09-11 16:33 ` Vineet Gupta
2017-09-14 10:44 ` Philipp Zabel
2017-09-27 18:07 ` Vineet Gupta [this message]
2017-09-28 8:21 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef62e890-e35a-e6fd-d8a4-9c2fbeaf8b9e@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox