From: Paul Sherwood <paul.sherwood@codethink.co.uk>
To: Phil Auld <pauld@redhat.com>
Cc: mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com,
vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
bristot@redhat.com, vschneid@redhat.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/deadline: Fix grammar and typos in comments
Date: Mon, 13 May 2024 16:19:10 +0100 [thread overview]
Message-ID: <ef7021835015a5bdd5bf5404ee712853@codethink.co.uk> (raw)
In-Reply-To: <20240513135812.GA9998@lorien.usersys.redhat.com>
On 2024-05-13 14:58, Phil Auld wrote:
> On Sat, May 11, 2024 at 09:26:44AM +0100 Paul Sherwood wrote:
>> - conjugate verb to match subject of sentence
>> - s/a entity/an entity/g
>> - s/this misbehave/this misbehaviour/
>> - a few typos
>>
> - not starting all the lines of a commit message with "-", priceless.
>
> Plus, you're just repeating what's in the actual patch.
>
> Otherwise, these changes themselves look good to me.
Thanks for the feedback - would you like me to re-submit without the
bullet-points, or without the text entirely?
br
Paul
next prev parent reply other threads:[~2024-05-13 15:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-11 8:26 [PATCH] sched/deadline: Fix grammar and typos in comments Paul Sherwood
2024-05-11 11:01 ` Bagas Sanjaya
2024-05-13 13:58 ` Phil Auld
2024-05-13 15:19 ` Paul Sherwood [this message]
2024-05-13 16:25 ` Phil Auld
2024-05-14 8:25 ` Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef7021835015a5bdd5bf5404ee712853@codethink.co.uk \
--to=paul.sherwood@codethink.co.uk \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox