From: John Garry <john.g.garry@oracle.com>
To: brauner@kernel.org, djwong@kernel.org, hch@lst.de,
viro@zeniv.linux.org.uk, jack@suse.cz, cem@kernel.org
Cc: linux-fsdevel@vger.kernel.org, dchinner@redhat.com,
linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
ojaswin@linux.ibm.com, ritesh.list@gmail.com,
martin.petersen@oracle.com, linux-ext4@vger.kernel.org,
linux-block@vger.kernel.org, catherine.hoang@oracle.com,
linux-api@vger.kernel.org
Subject: Re: [PATCH v12 17/17] xfs: allow sysadmins to specify a maximum atomic write limit at mount time
Date: Wed, 7 May 2025 16:14:50 +0100 [thread overview]
Message-ID: <ef7cec58-9347-46ac-9e1e-e49125940596@oracle.com> (raw)
In-Reply-To: <20250506090427.2549456-18-john.g.garry@oracle.com>
On 06/05/2025 10:04, John Garry wrote:
> From: "Darrick J. Wong"<djwong@kernel.org>
>
> Introduce a mount option to allow sysadmins to specify the maximum size
> of an atomic write. If the filesystem can work with the supplied value,
> that becomes the new guaranteed maximum.
>
> The value mustn't be too big for the existing filesystem geometry (max
> write size, max AG/rtgroup size). We dynamically recompute the
> tr_atomic_write transaction reservation based on the given block size,
> check that the current log size isn't less than the new minimum log size
> constraints, and set a new maximum.
>
> The actual software atomic write max is still computed based off of
> tr_atomic_ioend the same way it has for the past few commits. Note also
> that xfs_calc_atomic_write_log_geometry is non-static because mkfs will
> need that.
>
> Signed-off-by: Darrick J. Wong<djwong@kernel.org>
> Signed-off-by: John Garry<john.g.garry@oracle.com>
Reviewed-by: John Garry <john.g.garry@oracle.com>
prev parent reply other threads:[~2025-05-07 15:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 9:04 [PATCH v12 00/17] large atomic writes for xfs John Garry
2025-05-06 9:04 ` [PATCH v12 01/17] fs: add atomic write unit max opt to statx John Garry
2025-05-06 9:04 ` [PATCH v12 02/17] xfs: only call xfs_setsize_buftarg once per buffer target John Garry
2025-05-06 12:00 ` Christoph Hellwig
2025-05-06 9:04 ` [PATCH v12 03/17] xfs: rename xfs_inode_can_atomicwrite() -> xfs_inode_can_hw_atomic_write() John Garry
2025-05-06 9:04 ` [PATCH v12 04/17] xfs: separate out setting buftarg atomic writes limits John Garry
2025-05-06 9:04 ` [PATCH v12 05/17] xfs: add helpers to compute log item overhead John Garry
2025-05-06 9:04 ` [PATCH v12 06/17] xfs: add helpers to compute transaction reservation for finishing intent items John Garry
2025-05-06 9:04 ` [PATCH v12 07/17] xfs: ignore HW which cannot atomic write a single block John Garry
2025-05-06 9:04 ` [PATCH v12 08/17] xfs: allow block allocator to take an alignment hint John Garry
2025-05-06 9:04 ` [PATCH v12 09/17] xfs: refactor xfs_reflink_end_cow_extent() John Garry
2025-05-06 9:04 ` [PATCH v12 10/17] xfs: refine atomic write size check in xfs_file_write_iter() John Garry
2025-05-06 9:04 ` [PATCH v12 11/17] xfs: add xfs_atomic_write_cow_iomap_begin() John Garry
2025-05-06 9:04 ` [PATCH v12 12/17] xfs: add large atomic writes checks in xfs_direct_write_iomap_begin() John Garry
2025-05-06 9:04 ` [PATCH v12 13/17] xfs: commit CoW-based atomic writes atomically John Garry
2025-05-06 9:04 ` [PATCH v12 14/17] xfs: add xfs_file_dio_write_atomic() John Garry
2025-05-06 9:04 ` [PATCH v12 15/17] xfs: add xfs_calc_atomic_write_unit_max() John Garry
2025-05-06 9:04 ` [PATCH v12 16/17] xfs: update atomic write limits John Garry
2025-05-06 9:04 ` [PATCH v12 17/17] xfs: allow sysadmins to specify a maximum atomic write limit at mount time John Garry
2025-05-07 15:14 ` John Garry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef7cec58-9347-46ac-9e1e-e49125940596@oracle.com \
--to=john.g.garry@oracle.com \
--cc=brauner@kernel.org \
--cc=catherine.hoang@oracle.com \
--cc=cem@kernel.org \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox