From: abhinavk@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Jeykumar Sankaran <jsanka@codeaurora.org>,
freedreno@lists.freedesktop.org
Subject: Re: [Freedreno] [PATCH] drm/msm/dpu: Add newline to printks
Date: Mon, 28 Sep 2020 12:21:36 -0700 [thread overview]
Message-ID: <ef9767b5088a9ce33aaceccae3f6d458@codeaurora.org> (raw)
In-Reply-To: <20200928191657.1193583-1-swboyd@chromium.org>
On 2020-09-28 12:16, Stephen Boyd wrote:
> Printk messages need newlines. Add it here.
>
> Cc: Abhinav Kumar <abhinavk@codeaurora.org>
> Cc: Jeykumar Sankaran <jsanka@codeaurora.org>
> Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk@codeaurora.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index f272a8d0f95b..cbe0461246f8 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -906,7 +906,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc
> *crtc,
> }
>
> mode = &state->adjusted_mode;
> - DPU_DEBUG("%s: check", dpu_crtc->name);
> + DPU_DEBUG("%s: check\n", dpu_crtc->name);
>
> /* force a full mode set if active state changed */
> if (state->active_changed)
> @@ -1012,7 +1012,7 @@ static int dpu_crtc_atomic_check(struct drm_crtc
> *crtc,
> }
>
> pstates[i].dpu_pstate->stage = z_pos + DPU_STAGE_0;
> - DPU_DEBUG("%s: zpos %d", dpu_crtc->name, z_pos);
> + DPU_DEBUG("%s: zpos %d\n", dpu_crtc->name, z_pos);
> }
>
> for (i = 0; i < multirect_count; i++) {
prev parent reply other threads:[~2020-09-28 19:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 19:16 [PATCH] drm/msm/dpu: Add newline to printks Stephen Boyd
2020-09-28 19:21 ` abhinavk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef9767b5088a9ce33aaceccae3f6d458@codeaurora.org \
--to=abhinavk@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jsanka@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox