From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2ED7D2F2915 for ; Mon, 24 Nov 2025 22:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764022239; cv=none; b=rvzFSLqQJkQz2fWOn9oONjIfSDt73dMtA1UYUu51ok+F6MxhQ4dvxCicGNJWPPXQyvLglqNdfkj8HeJTvA0miKqHO6OW7HR4l0ALA7X/tjEZITzybE/pm7CsI+pOW/YcpVS9HXvOjfxaE001+8nqMTK419xtdfO99UwXJ13kCOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764022239; c=relaxed/simple; bh=5asoTe/RpVZq0z10toOW9rTiNGWjHr1jmYmj/9QBvhw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F/rFmDLdrRs4XOocAB414vZc2G/dtaN7lE9Y7704v75BV+oizbMyHwMCriWyQOsGuEVPt27vIZH7cWOzPF86Uq7tVsf995SOAqtF1mwa+pVwP7hNlhc0xMBNQhzYx3o60WdENjr5bmTWW+FshXghVi9T735LwD25yaJET7+EBLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IX8JCe81; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=hA3DkNwb; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IX8JCe81"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="hA3DkNwb" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5AOJrqjB971327 for ; Mon, 24 Nov 2025 22:10:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= P1IkRQX90E+6SINHSGTIxDgXOYU24GZeFnRVS4Zye7g=; b=IX8JCe81aZ4Z96ad LQ93m1F98NWgE2XRNocVygHnvwMc6pPv1IGhmTGeXZXEiwBpVbABwFB/Md3+rF+C nRBdK8UnvdLQZh4XU0JcNnIkdhgYRqGY+nOLkFZZ2jTaoZ4+VfSx1OHoOXmQdRIB dJxsXD8fTn/RD/AVsDThTFaAfNF5NHxrmgA4YxRvVI3dcQ3rWXtlknGEU/UvrvJ5 QE1lal5uNXo6TAa5uiQ5fmvMAL6Wei8+tiu8oU9jruplalbakG36bFa8Ln5e2gpW vh44BBkQF+s7PHnLtZ+qjnC1z3iomsRiCkOJpZXWLya7JB2A/l67ZJ0p3HeayXWP xvqMuw== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4amp6h1uta-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 24 Nov 2025 22:10:37 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-29557f43d56so60241695ad.3 for ; Mon, 24 Nov 2025 14:10:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764022236; x=1764627036; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P1IkRQX90E+6SINHSGTIxDgXOYU24GZeFnRVS4Zye7g=; b=hA3DkNwbpKUPIyYL+k23sJwQRhD52UqLnFEQxJ27RPFFvvUqdx4tOoAKdbd2m/ZbGE v7uvsIFOzOfg8psJuPh6yEOgb7JeXFNAslK0aGi81vvcp2z9tD365YbtT2galwQmCrsp XCIauSn3c59+/SCJbNfzaNvH0uN3kH23W1TlnqhJM2KgIM95SLxgkgZfgsF1Vd21CFdZ NYtz3NviVjKvGCwcv0mnkKo6bBlR7h6fm6vW/9ZAsIt5nyaVpKTtA+EAKmHVe7tEvQFt fZQvpc7xhLupU12GCmMPDmnKT5yO7Usl2WlsKsUAFcSUjTnhb68IKZno72RHaE1Kx/+a /nAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764022236; x=1764627036; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P1IkRQX90E+6SINHSGTIxDgXOYU24GZeFnRVS4Zye7g=; b=cN2SgisKBNbHbQj2NJBLIm1YnXL3nn+x9qRYizIAcoNmCWWQAMa2IfL32jsjcxKEjY Kt0ICUIKl9/nCB526Z7saUwCW2hyPfJBJWg9tom4EFD0pxRQX7QwCyWq8k4T9vu7KZgJ eWyQd8JcKiU4K8UhsQSTy1AnBSuSeSH/935nLqiH+pj+XNLdup4uuTN21VzrWTMtKQ/S 1FemwSr3XTZOW45eKjMSQdsqMYu3ShziyRuZRSreUux5KbQAQBEcFlVJUZZBtK2t6Ze6 a4s3TOKXSI2P7cKv6+XV8Jn+HxnmYSg699p4dXbbq5Aize2w5lckdx5tRgJOSSva5A+C IU6Q== X-Forwarded-Encrypted: i=1; AJvYcCW38Y61ah6nUst/U4QXBUAMqGHp8VXZ3C+e8E8Rxb6xsvIw+36XyLscDgSVCi3/fCU6C2nxY1J8huSrSUI=@vger.kernel.org X-Gm-Message-State: AOJu0YzORQEiDN42czssawspFT3fVXfmFbMKJPPLvJ70hVrKxj+R1Kt5 QrOpw/5CHQ+moQ1tU1Tmnf2AtUkbOzPAEJKo05X+ItD18MfclLIEzj48DdfsKXQzksQfky7cTMr yUMIMyRx7p/hzoKdc9tJ1jqZhupCS3kT7YQIXM/aEfBUieRuJKP35kT2fc7EoJwCzfOc= X-Gm-Gg: ASbGncubk+3wR2k2scIkc1YP8mXg9jtFOjT/yaZtrZo/T2bBEddiY/XzahwKzW44rsR zFPIXiEGk/xUhnRK7C5x7NAz6MLm6WIFUJx6duoUmF6GR8bdTDzUpDDP3sh1D77U7pS+GeUzUHL abp3uNxOI1YyGyfzWG+1FcfRClvpG78y8PHw48jp817Vt8V2f3SwgI3jyAN0n3vz145k3mnokSJ YHtHm4hALRG5vzHfJyELnjb60PwiORoQDu2jFf4Lm4gySbP8td1zW2tCWTIv56EmvG4wRYDQAnN k1TwPJy3YkfTzPDvfpb82DmPGHXBHQMimrWtkxqllsfXd0vMZSlJOIqBmBrsYTcWmaKDjBAMR+3 7cW57hG7xRS7GxlI6P4QCdoZuQIQmw30fhVs= X-Received: by 2002:a17:903:1aa5:b0:298:4ee3:c21a with SMTP id d9443c01a7336-29baae40a33mr4509265ad.2.1764022236561; Mon, 24 Nov 2025 14:10:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IGCFlcdURGFYX9T7gTdXnUcf8Uq2t38PcEn5iAANu+rMB94bLXIscK2ROxQ/LO/fYuI22iQTw== X-Received: by 2002:a17:903:1aa5:b0:298:4ee3:c21a with SMTP id d9443c01a7336-29baae40a33mr4508935ad.2.1764022236070; Mon, 24 Nov 2025 14:10:36 -0800 (PST) Received: from [192.168.1.14] ([106.222.231.199]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29b5b1387e3sm142941995ad.24.2025.11.24.14.10.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Nov 2025 14:10:35 -0800 (PST) Message-ID: Date: Tue, 25 Nov 2025 03:40:28 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] drm/msm/a6xx: Retrieve gmu core range by index To: Konrad Dybcio Cc: Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Marijn Suijten , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Jessica Zhang , Dan Carpenter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20251122-qcs615-spin-2-v3-0-9f4d4c87f51d@oss.qualcomm.com> <20251122-qcs615-spin-2-v3-1-9f4d4c87f51d@oss.qualcomm.com> <9cc55934-6980-4673-8501-2d1efe2f816e@oss.qualcomm.com> Content-Language: en-US From: Akhil P Oommen In-Reply-To: <9cc55934-6980-4673-8501-2d1efe2f816e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI0MDE5MiBTYWx0ZWRfX64JcicK2HeEP l7TDe20mPWQbSzA01uyQmcDEDI1a7SV/srCrvAsgkPZRzlVUkPSXlSe61ESUZ91FbKs/+KtycH+ +1oQ8X4QPgT1Pn3Qu6RnWSR0WA0SZoWGV4HQVG266E0reE4+T+4zqX+suUeXGnI4sL3cCoLdByl nlsRAWevkVNUyrQvL6l0A/2032FXuiQFkNAz4kRFvDnLgoD78hFsiecWkXBn2eOMqaKoPgO+SOq t651q0trTf84V14i3vYGO5CaGapFyL63gLweOHqigAqwaHR1VcR/2Y+ebJ6gLqiek4bmw5ZYSRy izCQZaQB9bZgcBpPu1tXcwY1nrS0/AHY36DJDapykNqaMfPQZ+mj4WvJADSnUaoWa6LzwjA3gFq EchjG1HR5qVCcmF4NwMFcHSGdAjF+g== X-Proofpoint-GUID: fCbrePmgdtADGcK-ZOrCz8VFfXWZxEuI X-Proofpoint-ORIG-GUID: fCbrePmgdtADGcK-ZOrCz8VFfXWZxEuI X-Authority-Analysis: v=2.4 cv=GoFPO01C c=1 sm=1 tr=0 ts=6924d7dd cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=QME20dCx57Gc1q/4dZKLgg==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=6yKHOGsdPNW3Y-1pzmYA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-24_08,2025-11-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 suspectscore=0 impostorscore=0 bulkscore=0 adultscore=0 phishscore=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511240192 On 11/22/2025 7:08 PM, Konrad Dybcio wrote: > On 11/21/25 10:52 PM, Akhil P Oommen wrote: >> Some GPUs like A612 doesn't use a named register range resource. This >> is because the reg-name property is discouraged when there is just a >> single resource. >> >> To address this, retrieve the 'gmu' register range by its index. It is >> always guaranteed to be at index 0. >> >> Signed-off-by: Akhil P Oommen >> --- >> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 14 ++++++-------- >> 1 file changed, 6 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >> index 5903cd891b49..9662201cd2e9 100644 >> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >> @@ -2029,21 +2029,19 @@ static int cxpd_notifier_cb(struct notifier_block *nb, >> return 0; >> } >> >> -static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, >> - const char *name, resource_size_t *start) >> +static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev, resource_size_t *start) > > Can we drop this and just use devm_platform_get_and_ioremap_resource()? That's better. Nice. -Akhil. > > Konrad