From: Nikolay Aleksandrov <razor@blackwall.org>
To: Danielle Ratson <danieller@nvidia.com>, netdev@vger.kernel.org
Cc: idosch@nvidia.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, horms@kernel.org,
shuah@kernel.org, bridge@lists.linux.dev,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] selftests: net: Add tests for ARP probe and DAD NS handling
Date: Wed, 29 Apr 2026 12:04:25 +0300 [thread overview]
Message-ID: <efa4eaf9-0c5f-4cea-ad9d-dd1052ccab76@blackwall.org> (raw)
In-Reply-To: <20260429062405.1386417-3-danieller@nvidia.com>
On 29/04/2026 09:24, Danielle Ratson wrote:
> Add test cases to verify that ARP probes and DAD Neighbor Solicitations
> are handled correctly by the bridge neighbor suppression feature.
>
> When neighbor suppression is enabled on a bridge VXLAN port, the bridge
> should reply to ARP/NS messages on behalf of remote hosts when both FDB
> and neighbor entries exist, and the answer is known. However, when
> either the FDB or the neighbor exists, ARP probes / DAD NS should be
> treated like regular ARP requests / NS and flood to VXLAN.
>
> Add two new test functions:
>
> neigh_suppress_arp_probe(): Tests ARP probe handling by triggering
> duplicate address detection using arping -D. Verifies that probes are
> flooded when the bridge doesn't know the answer, and suppressed when FDB
> and neighbor entries exist.
>
> neigh_suppress_dad_ns(): Tests DAD NS handling by constructing DAD NS
> packets using mausezahn and verifies correct flooding/suppression
> behavior.
>
> Before the previous patch:
>
> $ ./test_bridge_neigh_suppress.sh -t "neigh_suppress_arp_probe neigh_suppress_dad_ns"
>
> Per-port ARP probe suppression
> ------------------------------
> TEST: ARP probe suppression [ OK ]
> TEST: "neigh_suppress" is on [ OK ]
> TEST: ARP probe suppression [FAIL]
> TEST: FDB and neighbor entry installation [ OK ]
> TEST: arping [FAIL]
> TEST: ARP probe suppression [FAIL]
> TEST: neighbor removal [ OK ]
> TEST: ARP probe suppression [FAIL]
> TEST: "neigh_suppress" is off [ OK ]
> TEST: ARP probe suppression [FAIL]
>
> Per-port DAD NS suppression
> ---------------------------
> TEST: DAD NS suppression [ OK ]
> TEST: "neigh_suppress" is on [ OK ]
> TEST: DAD NS suppression [FAIL]
> TEST: FDB and neighbor entry installation [ OK ]
> TEST: DAD NS suppression [FAIL]
> TEST: neighbor removal [ OK ]
> TEST: DAD NS suppression [FAIL]
> TEST: DAD NS proxy NA reply [FAIL]
> TEST: "neigh_suppress" is off [ OK ]
> TEST: DAD NS suppression [FAIL]
>
> Tests passed: 10
> Tests failed: 10
>
> After the previous patch:
>
> $ ./test_bridge_neigh_suppress.sh -t "neigh_suppress_arp_probe neigh_suppress_dad_ns"
>
> Per-port ARP probe suppression
> ------------------------------
> TEST: ARP probe suppression [ OK ]
> TEST: "neigh_suppress" is on [ OK ]
> TEST: ARP probe suppression [ OK ]
> TEST: FDB and neighbor entry installation [ OK ]
> TEST: arping [ OK ]
> TEST: ARP probe suppression [ OK ]
> TEST: neighbor removal [ OK ]
> TEST: ARP probe suppression [ OK ]
> TEST: "neigh_suppress" is off [ OK ]
> TEST: ARP probe suppression [ OK ]
>
> Per-port DAD NS suppression
> ---------------------------
> TEST: DAD NS suppression [ OK ]
> TEST: "neigh_suppress" is on [ OK ]
> TEST: DAD NS suppression [ OK ]
> TEST: FDB and neighbor entry installation [ OK ]
> TEST: DAD NS suppression [ OK ]
> TEST: neighbor removal [ OK ]
> TEST: DAD NS suppression [ OK ]
> TEST: DAD NS proxy NA reply [ OK ]
> TEST: "neigh_suppress" is off [ OK ]
> TEST: DAD NS suppression [ OK ]
>
> Tests passed: 20
> Tests failed: 0
>
> Signed-off-by: Danielle Ratson <danieller@nvidia.com>
> ---
> .../net/test_bridge_neigh_suppress.sh | 126 ++++++++++++++++++
> 1 file changed, 126 insertions(+)
>
Acked-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2026-04-29 9:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 6:24 [PATCH net-next 0/2] bridge: Do not suppress ARP probes and DAD NS unconditionally Danielle Ratson
2026-04-29 6:24 ` [PATCH net-next 1/2] " Danielle Ratson
2026-04-29 9:04 ` Nikolay Aleksandrov
2026-04-30 10:33 ` Danielle Ratson
2026-04-29 6:24 ` [PATCH net-next 2/2] selftests: net: Add tests for ARP probe and DAD NS handling Danielle Ratson
2026-04-29 9:04 ` Nikolay Aleksandrov [this message]
2026-05-01 1:10 ` [PATCH net-next 0/2] bridge: Do not suppress ARP probes and DAD NS unconditionally patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efa4eaf9-0c5f-4cea-ad9d-dd1052ccab76@blackwall.org \
--to=razor@blackwall.org \
--cc=bridge@lists.linux.dev \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox