From: Thejasvi Konduru <t-konduru@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Andrew Davis <afd@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
Apurva Nandan <a-nandan@ti.com>, Udit Kumar <u-kumar1@ti.com>
Subject: Re: [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and pinctrl node offsets
Date: Tue, 9 May 2023 15:19:40 +0530 [thread overview]
Message-ID: <efab17de-aeb4-9fdb-6c97-ab2f2bc8c8f4@ti.com> (raw)
In-Reply-To: <20230504142239.hqhni2c52k3a3asz@prune>
On 04/05/23 19:52, Nishanth Menon wrote:
> On 17:40-20230504, Thejasvi Konduru wrote:
>> On 04/05/23 17:22, Nishanth Menon wrote:
>>> On 14:36-20230504, Thejasvi Konduru wrote:
>>>> On 03/05/23 17:16, Nishanth Menon wrote:
>>>>> On 14:01-20230503, Thejasvi Konduru wrote:
>>>>>> The wkup_pmx register region in j784s4 has multiple non-addressable
>>>>>> regions, hence the existing wkup_pmx region is split as follows to
>>>>>> avoid the non-addressable regions. The pinctrl node offsets are
>>>>>> also corrected as per the newly split wkup_pmx* nodes.
>>>>>>
>>>>>> wkup_pmx0 -> 13 pins (WKUP_PADCONFIG 0 - 12)
>>>>>> wkup_pmx1 -> 11 pins (WKUP_PADCONFIG 14 - 24)
>>>>>> wkup_pmx2 -> 72 pins (WKUP_PADCONFIG 26 - 97)
>>>>>> wkup_pmx3 -> 1 pin (WKUP_PADCONFIG 100)
>>>>>>
>>>>>> Fixes: 4664ebd8346a ("arm64: dts: ti: Add initial support for J784S4 SoC")
>>>>>> Signed-off-by: Thejasvi Konduru <t-konduru@ti.com>
>>>>>> ---
>>>>> Could you provide a link to the output of:
>>>>> $ cat /sys/kernel/debug/pinctrl/*/pins
>>>> https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a
>>> Was this failing prior to this patch? Trying to understand the "Fix"
>>> aspect of this patch.
>>>
>> Yes,it was failing prior to this patch.
>>
> next time some asks this question - give summary AND give a log. Even
> better, please don't make folks even ask the question in the first
> place by including the logs in the diffstat of the patch.
>
> Please share the log to understand what kind of "failure" was occurring.
Link to logs:
Before Fix: https://gist.github.com/thejasvikonduru/e217edf4839c348793a5671aa9331595
After Fix : https://gist.github.com/thejasvikonduru/05b1a8e0fd8176116b7a3cc4e43b244a
>
next prev parent reply other threads:[~2023-05-09 9:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 8:31 [PATCH] arm64: dts: ti: k3-j784s4: Fix wakeup pinmux range and pinctrl node offsets Thejasvi Konduru
2023-05-03 11:46 ` Nishanth Menon
2023-05-04 9:06 ` Thejasvi Konduru
2023-05-04 11:52 ` Nishanth Menon
2023-05-04 12:10 ` Thejasvi Konduru
2023-05-04 14:22 ` Nishanth Menon
2023-05-09 9:49 ` Thejasvi Konduru [this message]
2023-06-01 11:48 ` Thejasvi Konduru
2023-06-02 21:24 ` Nishanth Menon
2023-06-15 13:28 ` Vignesh Raghavendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efab17de-aeb4-9fdb-6c97-ab2f2bc8c8f4@ti.com \
--to=t-konduru@ti.com \
--cc=a-nandan@ti.com \
--cc=afd@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
--cc=u-kumar1@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox