From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CF9426AABF for ; Tue, 18 Feb 2025 14:57:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739890641; cv=none; b=jxZzeMwwJNcHvjjwAnOeCSsux2Bi51xm3TBR1vBAGEgxuigOTgcWehw4NFIg0NODue/rwqtDqRUDGqw9UMYbHHw926wMxcp7rUibYmxau0ltXXLCohEwJNdMRBnMKBUuwEulkVGKnZmYXr19Tnn/aDr6872n4uFRihtpEn1Si5M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739890641; c=relaxed/simple; bh=tkzBRjr0ZYnzfzrcQzw0A/TkfNA5oVNet8zEjRq8tjQ=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=O2iXDzSPWGDoadMz8JVPG44t/t+p4MtG5FSk5E5olzfw8cL7pHNKjQFRVKhQUAkU2MWZuimgEJ308aQ6UNysnKp0g16N7FNI9qKsjzz6s6Z4dH5eC6107QLBCUKlgQb+U/EOSiNOLl8ZltTv325Mfh6vqGnW8FhwXV2KxwsIkzg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Abvx6xLI; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Abvx6xLI" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739890639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x+4AZod0zwwoKSkEdpQmvjuKbyYTyP5Z7/IeKW01Ztg=; b=Abvx6xLIevjBwIpiS6g0IZjrsAprmpV511L+TMYmYlZOYBVMXd1smImGljpEXeJX17iDe4 nmK3OXrE2gROYoZr3vfE0uCqH/0tcwg1f+dHDO0YU0r7c5+sV2d67MlqpzHz9yTulEmQuB x4O3kT5EDzjZWclEFYw+DBJZniyYcI0= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-665-bkK2-au8O8CFbsTrdqMeEA-1; Tue, 18 Feb 2025 09:57:15 -0500 X-MC-Unique: bkK2-au8O8CFbsTrdqMeEA-1 X-Mimecast-MFC-AGG-ID: bkK2-au8O8CFbsTrdqMeEA_1739890634 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 43EE418EB2C9; Tue, 18 Feb 2025 14:57:14 +0000 (UTC) Received: from [10.22.65.116] (unknown [10.22.65.116]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 121BE1956094; Tue, 18 Feb 2025 14:57:11 +0000 (UTC) Message-ID: Date: Tue, 18 Feb 2025 09:57:10 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvme: remove multipath module parameter From: John Meneghini To: Sagi Grimberg , kbusch@kernel.org, hch@lst.de Cc: bmarzins@redhat.com, Bryan Gurney , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Marco Patalano , axboe@kernel.dk References: <20250204211158.43126-1-bgurney@redhat.com> <7c588344-f019-4939-8a93-0a450481d4bc@redhat.com> <87850a70-4a93-492f-a6b5-fec5d5480cf4@redhat.com> Content-Language: en-US Organization: RHEL Core Storge Team In-Reply-To: <87850a70-4a93-492f-a6b5-fec5d5480cf4@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 On 2/18/25 9:05 AM, John Meneghini wrote: > +               if (info->is_shared) { > +                       dev_warn(ctrl->device, > +                               "Found shared namespace %d but multipathing not supported.\n", > +                               info->nsid); Or maybe this should be + if ((ctrl->subsys->cmic & NVME_CTRL_CMIC_MULTI_CTRL) && info->is_shared) { + dev_warn(ctrl->device, + "Found shared namespace %d but multipathing not supported.\n", + info->nsid); /John