From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Mark Brown <broonie@kernel.org>
Cc: yung-chuan.liao@linux.intel.com, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH] ASoC: cs35l56: Support clock stop mode 1 if enabled in ACPI
Date: Wed, 11 Mar 2026 15:17:16 +0000 [thread overview]
Message-ID: <efbbabe3-b42e-4f54-bef4-d27744f4309f@opensource.cirrus.com> (raw)
In-Reply-To: <80ba7c33-7949-4940-a72c-582ba749b2e7@sirena.org.uk>
On 11/03/2026 3:03 pm, Mark Brown wrote:
> On Wed, Mar 11, 2026 at 02:21:53PM +0000, Richard Fitzgerald wrote:
>
>> + ret = fwnode_property_read_u8(dev_fwnode(cs35l56->base.dev),
>> + "mipi-sdw-clock-stop-mode1-supported",
>> + &clock_stop_1);
>> + if (ret == 0)
>> + prop->clk_stop_mode1 = !!clock_stop_1;
>
> Should this be using fwnode_property_read_bool()?
No, that only reports whether the property exists (it calls
acpi_fwnode_property_present()).
The property can (and usually does) exist with value 0 to disable
clock-stop-mode1.
I copied the use of fwnode_property_read_u8() to read this property from
the implementation of sdw_slave_read_prop().
next prev parent reply other threads:[~2026-03-11 15:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 14:21 [PATCH] ASoC: cs35l56: Support clock stop mode 1 if enabled in ACPI Richard Fitzgerald
2026-03-11 15:03 ` Mark Brown
2026-03-11 15:17 ` Richard Fitzgerald [this message]
2026-03-11 15:30 ` Mark Brown
2026-03-11 15:34 ` Richard Fitzgerald
2026-03-11 15:50 ` Mark Brown
2026-03-11 15:58 ` Richard Fitzgerald
2026-03-11 16:09 ` Mark Brown
2026-03-11 18:56 ` Mark Brown
2026-03-14 21:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efbbabe3-b42e-4f54-bef4-d27744f4309f@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox