From: Cezary Rojewski <cezary.rojewski@intel.com>
To: "Radosław Biernacki" <rad@semihalf.com>
Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Jie Yang <yang.jie@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Lech Betlej <Lech.Betlej@intel.com>,
alsa-devel@alsa-project.org, Todd Broch <tbroch@google.com>,
Harshapriya <harshapriya.n@intel.com>,
John Hsu <KCHSU0@nuvoton.com>,
linux-kernel@vger.kernel.org, "Sienkiewicz,
Michal" <michal.sienkiewicz@intel.com>,
Ben Zhang <benzh@chromium.org>, Mac Chiang <mac.chiang@intel.com>,
Yong Zhi <yong.zhi@intel.com>, Marcin Wojtas <mw@semihalf.com>,
Vamshi Krishna <vamshi.krishna.gopal@intel.com>,
Alex Levin <levinale@google.com>
Subject: Re: [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine
Date: Tue, 5 May 2020 17:57:32 +0200 [thread overview]
Message-ID: <efca85c3-7078-efaa-88b5-536c8debea3d@intel.com> (raw)
In-Reply-To: <CAOs-w0LPeKgooa_98x_Jkzus-Y5Kad7pDby0CriDGb6nTp_6sA@mail.gmail.com>
>>>
>>> 2) Currently Skylake does not output MCLK/FS when the back-end DAI op
>>> hw_param is called, so we cannot switch to MCLK/FS in hw_param. This
>>> patch reduces pop by letting nau8825 keep using its internal VCO clock
>>> during widget power up sequence, until SNDRV_PCM_TRIGGER_START when
>>> MCLK/FS is available. Once device resumes, the system will only enable
>>> power sequence for playback without doing hardware parameter, audio
>>> format, and PLL configure. In the mean time, the jack detecion sequence
>>> has changed PLL parameters and switched to internal clock. Thus, the
>>> playback signal distorted without correct PLL parameters. That is why
>>> we need to configure the PLL again in SNDRV_PCM_TRIGGER_RESUME case.
>>
>> IIRC the FS can be controlled with the clk_ api with the Skylake driver,
>> as done for some KBL platforms. Or is this not supported by the firmware
>> used by this machine?
>
> According to Ben, SKL had limitations in FW for managing the clk's
> back in the days.
> Can you point to the other driver you mention so we can cross check?
>
Skylake driver is found within:
/sound/soc/intel/skylake
directory.
"SKL had limitations in FW" - that's misleading. This is neither FW
issue nor HW 'limitation'. SKL is an older platform and its goals and
design was different than say APL+. Basically, your needs do not align
with what's present on SKL hw.
Czarek
next prev parent reply other threads:[~2020-05-05 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-01 19:31 [PATCH V2] ASoC: Intel: boards: Use FS as nau8825 sysclk in nau88125_* machine Radoslaw Biernacki
2020-05-01 20:16 ` Pierre-Louis Bossart
2020-05-05 14:23 ` Radosław Biernacki
2020-05-05 15:00 ` Pierre-Louis Bossart
2020-09-08 17:42 ` Radosław Biernacki
2020-09-08 18:06 ` Pierre-Louis Bossart
2020-09-08 18:24 ` Radosław Biernacki
2020-05-05 15:57 ` Cezary Rojewski [this message]
2020-05-02 11:00 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efca85c3-7078-efaa-88b5-536c8debea3d@intel.com \
--to=cezary.rojewski@intel.com \
--cc=KCHSU0@nuvoton.com \
--cc=Lech.Betlej@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=benzh@chromium.org \
--cc=harshapriya.n@intel.com \
--cc=levinale@google.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=michal.sienkiewicz@intel.com \
--cc=mw@semihalf.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rad@semihalf.com \
--cc=tbroch@google.com \
--cc=tiwai@suse.com \
--cc=vamshi.krishna.gopal@intel.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox