From: "David Hildenbrand (Arm)" <david@kernel.org>
To: Barry Song <baohua@kernel.org>
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Lorenzo Stoakes <ljs@kernel.org>,
Zi Yan <ziy@nvidia.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Nico Pache <npache@redhat.com>,
Ryan Roberts <ryan.roberts@arm.com>, Dev Jain <dev.jain@arm.com>,
Lance Yang <lance.yang@linux.dev>, Chris Li <chrisl@kernel.org>,
Kairui Song <kasong@tencent.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Nhat Pham <nphamcs@gmail.com>, Baoquan He <bhe@redhat.com>,
Youngjun Park <youngjun.park@lge.com>
Subject: Re: [PATCH] mm/huge_memory: Fix outdated comment about freeing subpages in __folio_split
Date: Tue, 28 Apr 2026 12:08:02 +0200 [thread overview]
Message-ID: <efcdb62c-54e9-4806-87a2-5729e3c1506d@kernel.org> (raw)
In-Reply-To: <CAGsJ_4y6_G5BPZKs3Mg3s2ygxGh1o22GX_3wEsM5hs7WX_cOhQ@mail.gmail.com>
On 4/28/26 12:05, Barry Song wrote:
> On Mon, Apr 27, 2026 at 3:42 PM David Hildenbrand (Arm)
> <david@kernel.org> wrote:
>>
>> On 4/26/26 22:42, Barry Song wrote:
>>> On Thu, Apr 23, 2026 at 8:36 PM David Hildenbrand (Arm)
>>> <david@kernel.org> wrote:
>>>
>>> Thanks, david! would it make more sense to add “when
>>> CONFIG_PAGE_MAPCOUNT is enabled” at the end of the
>>> sentence?
>>
>> Better to phrase it in a way that doesn't even require these details :)
>>
>> Do we even need this detail in the patch description?
>
> What about:
>
> The comment appears to be outdated. add_to_swap() no longer exists,
> and the explanation of why we need to call put_page() after
> splitting could be made more general.
Jup :)
--
Cheers,
David
next prev parent reply other threads:[~2026-04-28 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 3:49 [PATCH] mm/huge_memory: Fix outdated comment about freeing subpages in __folio_split Barry Song (Xiaomi)
2026-04-23 12:36 ` David Hildenbrand (Arm)
2026-04-26 20:42 ` Barry Song
2026-04-27 7:42 ` David Hildenbrand (Arm)
2026-04-28 10:05 ` Barry Song
2026-04-28 10:08 ` David Hildenbrand (Arm) [this message]
2026-04-28 10:32 ` Barry Song
2026-04-28 13:01 ` Andrew Morton
2026-04-28 22:55 ` Barry Song
2026-04-25 14:25 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efcdb62c-54e9-4806-87a2-5729e3c1506d@kernel.org \
--to=david@kernel.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=baohua@kernel.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=bhe@redhat.com \
--cc=chrisl@kernel.org \
--cc=dev.jain@arm.com \
--cc=kasong@tencent.com \
--cc=lance.yang@linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=npache@redhat.com \
--cc=nphamcs@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=youngjun.park@lge.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox