Re: [PATCH v4 1/7] x86/resctrl: Add multiple tasks to the resctrl group at once

Ilpo Järvinen
2023-04-20T09:43:27Z

[-- Attachment #1: Type: text/plain, Size: 1869 bytes --]

On Wed, 19 Apr 2023, Moger, Babu wrote:

> Hi Jarvinen,
>
> On 4/19/23 07:58, Ilpo Järvinen wrote:
> > On Mon, 17 Apr 2023, Babu Moger wrote:
> >
> >> The resctrl task assignment for MONITOR or CONTROL group needs to be
> >> done one at a time. For example:
> >>
> >> $mount -t resctrl resctrl /sys/fs/resctrl/
> >> $mkdir /sys/fs/resctrl/clos1
> >> $echo 123 > /sys/fs/resctrl/clos1/tasks
> >> $echo 456 > /sys/fs/resctrl/clos1/tasks
> >> $echo 789 > /sys/fs/resctrl/clos1/tasks
> >>
> >> This is not user-friendly when dealing with hundreds of tasks.
> >>
> >> It can be improved by supporting the multiple task id assignment in
> >> one command with the tasks separated by commas. For example:
> >>
> >> $echo 123,456,789 > /sys/fs/resctrl/clos1/tasks
> >>
> >> Signed-off-by: Babu Moger <babu.moger@amd.com>
> >> ---
> >> Documentation/x86/resctrl.rst | 9 ++++++++-
> >> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 31 ++++++++++++++++++++++++++++++-
> >> 2 files changed, 38 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/Documentation/x86/resctrl.rst b/Documentation/x86/resctrl.rst
> >> index 387ccbcb558f..f28ed1443a6a 100644
> >> --- a/Documentation/x86/resctrl.rst
> >> +++ b/Documentation/x86/resctrl.rst
> >> @@ -292,7 +292,14 @@ All groups contain the following files:
> >> "tasks":
> >> Reading this file shows the list of all tasks that belong to
> >> this group. Writing a task id to the file will add a task to the
> >> - group. If the group is a CTRL_MON group the task is removed from
> >> + group. Multiple tasks can be added by separating the task ids
> >> + with commas. Tasks will be assigned sequentially in the order it
> >> + is entered.
> >
> > "Tasks ... it is ..." doesn't sound correct.
>
> How about "Tasks will be assigned sequentially in the order they are entered."

It sounds better.

--
i.