Re: [PATCH v4 3/7] x86/resctrl: Rename rftype flags for consistency

Ilpo Järvinen
2023-04-19T12:44:54Z

On Mon, 17 Apr 2023, Babu Moger wrote:

> The rftype flags have two different prefixes even though they are used
> for the same purpose. Change the prefix to RFTYPE_ for all the flags.
>
> Signed-off-by: Babu Moger <babu.moger@amd.com>
> ---
> arch/x86/kernel/cpu/resctrl/internal.h | 8 +++---
> arch/x86/kernel/cpu/resctrl/rdtgroup.c | 42 ++++++++++++++++----------------
> 2 files changed, 25 insertions(+), 25 deletions(-)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 62767774810d..c4fc5a1c630c 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -248,10 +248,10 @@ struct rdtgroup {
> #define RFTYPE_TOP BIT(6)
> #define RFTYPE_RES_CACHE BIT(8)
> #define RFTYPE_RES_MB BIT(9)
> -#define RF_CTRL_INFO (RFTYPE_INFO | RFTYPE_CTRL)
> -#define RF_MON_INFO (RFTYPE_INFO | RFTYPE_MON)
> -#define RF_TOP_INFO (RFTYPE_INFO | RFTYPE_TOP)
> -#define RF_CTRL_BASE (RFTYPE_BASE | RFTYPE_CTRL)
> +#define RFTYPE_CTRL_INFO (RFTYPE_INFO | RFTYPE_CTRL)
> +#define RFTYPE_MON_INFO (RFTYPE_INFO | RFTYPE_MON)
> +#define RFTYPE_TOP_INFO (RFTYPE_INFO | RFTYPE_TOP)
> +#define RFTYPE_CTRL_BASE (RFTYPE_BASE | RFTYPE_CTRL)
>
> /* List of all resource groups */
> extern struct list_head rdt_all_groups;

This needs to be changed as well:

* @fflags: File specific RF_* or RFTYPE_* flags

--
i.