RE: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags

Moger, Babu
2023-05-05T19:04:17Z

[AMD Official Use Only - General]

Hi Reinette,

> -----Original Message-----
> From: Reinette Chatre <reinette.chatre@intel.com>
> Sent: Friday, May 5, 2023 1:54 PM
> To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
> tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
> Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com; x86@kernel.org;
> hpa@zytor.com; paulmck@kernel.org; akpm@linux-foundation.org;
> quic_neeraju@quicinc.com; rdunlap@infradead.org;
> damien.lemoal@opensource.wdc.com; songmuchun@bytedance.com;
> peterz@infradead.org; jpoimboe@kernel.org; pbonzini@redhat.com;
> chang.seok.bae@intel.com; pawan.kumar.gupta@linux.intel.com;
> jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
> <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com;
> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
> bagasdotme@gmail.com; eranian@google.com; christophe.leroy@csgroup.eu;
> jarkko@kernel.org; adrian.hunter@intel.com; quic_jiles@quicinc.com;
> peternewman@google.com
> Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype flags
>
> Hi Babu,
>
> On 5/5/2023 11:31 AM, Moger, Babu wrote:
> > [AMD Official Use Only - General]
> >
> > Hi Reinette,
> >
> >> -----Original Message-----
> >> From: Reinette Chatre <reinette.chatre@intel.com>
> >> Sent: Thursday, May 4, 2023 1:59 PM
> >> To: Moger, Babu <Babu.Moger@amd.com>; corbet@lwn.net;
> >> tglx@linutronix.de; mingo@redhat.com; bp@alien8.de
> >> Cc: fenghua.yu@intel.com; dave.hansen@linux.intel.com;
> >> x86@kernel.org; hpa@zytor.com; paulmck@kernel.org;
> >> akpm@linux-foundation.org; quic_neeraju@quicinc.com;
> >> rdunlap@infradead.org; damien.lemoal@opensource.wdc.com;
> >> songmuchun@bytedance.com; peterz@infradead.org;
> jpoimboe@kernel.org;
> >> pbonzini@redhat.com; chang.seok.bae@intel.com;
> >> pawan.kumar.gupta@linux.intel.com;
> >> jmattson@google.com; daniel.sneddon@linux.intel.com; Das1, Sandipan
> >> <Sandipan.Das@amd.com>; tony.luck@intel.com; james.morse@arm.com;
> >> linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> bagasdotme@gmail.com; eranian@google.com;
> >> christophe.leroy@csgroup.eu; jarkko@kernel.org;
> >> adrian.hunter@intel.com; quic_jiles@quicinc.com;
> >> peternewman@google.com
> >> Subject: Re: [PATCH v4 2/7] x86/resctrl: Remove unnecessary rftype
> >> flags
> >>
> >> Hi Babu,
> >>
> >> On 4/17/2023 4:34 PM, Babu Moger wrote:
> >>> Remove unnecessary rftype flags to avoid multiple indirection.
> >>
> >> Could you please elaborate what makes these flags unnecessary?
> >
> > Yea. Probably should not say unnecessary.
> > How about this ?
> > "rftype flags have two prefixes, RFTYPE_ and RF_. Remove the flag names
> with suffix RF_ and avoid indirection."
>
> I do not think that having a different prefix is a motivation for a flag to be
> removed. Having a different prefix could rather be a motivation for a flag to be
> renamed to a consistent name.
>
> Could you please describe the problem being solved?

Motivation for these changes.
1. Remove the naming inconsistency
2. Remove the indirection
3. Make it easier for adding new flags

Thanks
Babu

> That will help to clarify if this patch is really needed.
>
> Reinette