From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B212C433E0 for ; Fri, 19 Feb 2021 19:14:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2170C64E43 for ; Fri, 19 Feb 2021 19:14:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229937AbhBSTOP (ORCPT ); Fri, 19 Feb 2021 14:14:15 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:47379 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229652AbhBSTON (ORCPT ); Fri, 19 Feb 2021 14:14:13 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1613762030; h=Message-ID: References: In-Reply-To: Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=lhn8TVO1gUI2MG+vp5dxOFczztpu4wvavm9jaFIgGO4=; b=aNHz6OO5ntzpZEguClxC7xic8MzZRXjbAoCCszAMmAqiWrdfe10w++W4J4kPY9SKiw/ib3KB n3in3bcKneEsUjWgtDa3CycvAXwES401SraJ0DuT4ML+z7tuRXdpGG6IyYnCdzNrBLhb67Rf E+LpBCcTHk8TslGcd6paVOYyoqg= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 60300dcc37f02eb71442a757 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 19 Feb 2021 19:13:16 GMT Sender: bbhatt=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BD4F8C43461; Fri, 19 Feb 2021 19:13:16 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1DF40C433C6; Fri, 19 Feb 2021 19:13:16 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 19 Feb 2021 11:13:16 -0800 From: Bhaumik Bhatt To: Jeffrey Hugo Cc: manivannan.sadhasivam@linaro.org, linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, carl.yin@quectel.com, naveen.kumar@quectel.com, jhugo=codeaurora.org@codeaurora.org Subject: Re: [PATCH v4 1/3] bus: mhi: core: Clear devices when moving execution environments Organization: Qualcomm Innovation Center, Inc. Reply-To: bbhatt@codeaurora.org Mail-Reply-To: bbhatt@codeaurora.org In-Reply-To: <3b3476ff-3126-097a-5d1b-130ac570cce6@codeaurora.org> References: <1613701052-38885-1-git-send-email-bbhatt@codeaurora.org> <1613701052-38885-2-git-send-email-bbhatt@codeaurora.org> <3b3476ff-3126-097a-5d1b-130ac570cce6@codeaurora.org> Message-ID: X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-02-19 08:10 AM, Jeffrey Hugo wrote: > On 2/18/2021 7:17 PM, Bhaumik Bhatt wrote: >> When moving from SBL to mission mode execution environment, there >> is no remove callback notification to MHI client drivers which >> operate on SBL mode only. Client driver devices are being created >> in SBL or AMSS(mission mode) and only destroyed after power down >> or SYS_ERROR. If there exist any SBL-specific channels, those are >> left open and client drivers are thus unaware of the new execution >> environment where those channels cannot operate. Close the gap and >> issue remove callbacks to SBL-specific client drivers once device >> enters mission mode. >> >> Signed-off-by: Bhaumik Bhatt >> --- > > I like the idea, but I question where this is limited to the > transition to mission mode. Feels like something that should occur on > all EE changes. We might not have a current usecase that is outside > what you've implemented here, but I don't think there is anything > preventing that in future. You're right. It should not be limited to any single EE transition and that's how the code is written. I see my commit message gives the impression that it's only for SBL -> AMSS. I can correct that and mention it to be EE transition agnostic with SBL to AMSS as the currently usable example. Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project