* [PATCH] erofs: fix inode metadata space layout description in documentation
@ 2023-10-10 11:39 Tiwei Bie
2023-10-10 12:44 ` Jingbo Xu
2023-10-10 13:06 ` Gao Xiang
0 siblings, 2 replies; 6+ messages in thread
From: Tiwei Bie @ 2023-10-10 11:39 UTC (permalink / raw)
To: linux-erofs, xiang
Cc: ayushranjan, Tiwei Bie, Chao Yu, Yue Hu, Jeffle Xu,
Jonathan Corbet, Greg Kroah-Hartman, linux-doc, linux-kernel
Xattrs, extents, data inline are _placed after_, not _followed by_ the
corresponding inode. This patch fixes it.
Fixes: fdb0536469cb ("staging: erofs: add document")
Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
---
Documentation/filesystems/erofs.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
index f200d7874495..57c6ae23b3fc 100644
--- a/Documentation/filesystems/erofs.rst
+++ b/Documentation/filesystems/erofs.rst
@@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
| |
|__________________| 64 bytes
- Xattrs, extents, data inline are followed by the corresponding inode with
+ Xattrs, extents, data inline are placed after the corresponding inode with
proper alignment, and they could be optional for different data mappings.
_currently_ total 5 data layouts are supported:
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] erofs: fix inode metadata space layout description in documentation
2023-10-10 11:39 [PATCH] erofs: fix inode metadata space layout description in documentation Tiwei Bie
@ 2023-10-10 12:44 ` Jingbo Xu
2023-10-10 13:06 ` Gao Xiang
1 sibling, 0 replies; 6+ messages in thread
From: Jingbo Xu @ 2023-10-10 12:44 UTC (permalink / raw)
To: Tiwei Bie, linux-erofs, xiang
Cc: ayushranjan, Chao Yu, Yue Hu, Jonathan Corbet, Greg Kroah-Hartman,
linux-doc, linux-kernel
On 10/10/23 7:39 PM, Tiwei Bie wrote:
> Xattrs, extents, data inline are _placed after_, not _followed by_ the
> corresponding inode. This patch fixes it.
>
> Fixes: fdb0536469cb ("staging: erofs: add document")
> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
> ---
> Documentation/filesystems/erofs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> index f200d7874495..57c6ae23b3fc 100644
> --- a/Documentation/filesystems/erofs.rst
> +++ b/Documentation/filesystems/erofs.rst
> @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
> | |
> |__________________| 64 bytes
>
> - Xattrs, extents, data inline are followed by the corresponding inode with
> + Xattrs, extents, data inline are placed after the corresponding inode with
> proper alignment, and they could be optional for different data mappings.
> _currently_ total 5 data layouts are supported:
>
Thanks for catching it!
Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
--
Thanks,
Jingbo
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] erofs: fix inode metadata space layout description in documentation
2023-10-10 11:39 [PATCH] erofs: fix inode metadata space layout description in documentation Tiwei Bie
2023-10-10 12:44 ` Jingbo Xu
@ 2023-10-10 13:06 ` Gao Xiang
2023-10-10 13:39 ` Tiwei Bie
2023-10-12 1:10 ` Chao Yu
1 sibling, 2 replies; 6+ messages in thread
From: Gao Xiang @ 2023-10-10 13:06 UTC (permalink / raw)
To: Tiwei Bie, linux-erofs, xiang
Cc: Jonathan Corbet, Greg Kroah-Hartman, linux-doc, linux-kernel,
ayushranjan, Yue Hu
Hi Tiwei,
On 2023/10/10 19:39, Tiwei Bie via Linux-erofs wrote:
> Xattrs, extents, data inline are _placed after_, not _followed by_ the
> corresponding inode. This patch fixes it
Thanks for the patch and sorry about my terrible English...
>
> Fixes: fdb0536469cb ("staging: erofs: add document")
I'm not sure if it's necessary to tag document fixes anyway
since docs.kernel.org already uses the latest version and
`.rst` format is adapted much later..
I will drop this tag for the next merge window if not urgent.
> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Thanks,
Gao Xiang
> ---
> Documentation/filesystems/erofs.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/filesystems/erofs.rst b/Documentation/filesystems/erofs.rst
> index f200d7874495..57c6ae23b3fc 100644
> --- a/Documentation/filesystems/erofs.rst
> +++ b/Documentation/filesystems/erofs.rst
> @@ -199,7 +199,7 @@ may not. All metadatas can be now observed in two different spaces (views):
> | |
> |__________________| 64 bytes
>
> - Xattrs, extents, data inline are followed by the corresponding inode with
> + Xattrs, extents, data inline are placed after the corresponding inode with
> proper alignment, and they could be optional for different data mappings.
> _currently_ total 5 data layouts are supported:
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] erofs: fix inode metadata space layout description in documentation
2023-10-10 13:06 ` Gao Xiang
@ 2023-10-10 13:39 ` Tiwei Bie
2023-10-12 1:10 ` Chao Yu
1 sibling, 0 replies; 6+ messages in thread
From: Tiwei Bie @ 2023-10-10 13:39 UTC (permalink / raw)
To: Gao Xiang, linux-erofs, xiang
Cc: Jonathan Corbet, Greg Kroah-Hartman, linux-doc, linux-kernel,
ayushranjan, Yue Hu
On 10/10/23 9:06 PM, Gao Xiang wrote:
>> Fixes: fdb0536469cb ("staging: erofs: add document")
>
> I'm not sure if it's necessary to tag document fixes anyway
> since docs.kernel.org already uses the latest version and
> `.rst` format is adapted much later..
>
> I will drop this tag for the next merge window if not urgent.
Thanks! This patch is not urgent. :)
Regards,
Tiwei
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] erofs: fix inode metadata space layout description in documentation
2023-10-10 13:06 ` Gao Xiang
2023-10-10 13:39 ` Tiwei Bie
@ 2023-10-12 1:10 ` Chao Yu
2023-10-12 2:01 ` Gao Xiang
1 sibling, 1 reply; 6+ messages in thread
From: Chao Yu @ 2023-10-12 1:10 UTC (permalink / raw)
To: Gao Xiang, Tiwei Bie, linux-erofs, xiang
Cc: linux-doc, Greg Kroah-Hartman, Jonathan Corbet, linux-kernel,
ayushranjan, Yue Hu
On 2023/10/10 21:06, Gao Xiang wrote:
>> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
>
> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Looks fine to me for the version in dev-test branch.
Reviewed-by: Chao Yu <chao@kernel.org>
Thanks,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] erofs: fix inode metadata space layout description in documentation
2023-10-12 1:10 ` Chao Yu
@ 2023-10-12 2:01 ` Gao Xiang
0 siblings, 0 replies; 6+ messages in thread
From: Gao Xiang @ 2023-10-12 2:01 UTC (permalink / raw)
To: Chao Yu, Tiwei Bie, linux-erofs, xiang
Cc: linux-doc, Greg Kroah-Hartman, Jonathan Corbet, linux-kernel,
ayushranjan, Yue Hu
Hi Chao,
On 2023/10/12 09:10, Chao Yu wrote:
> On 2023/10/10 21:06, Gao Xiang wrote:
>>> Signed-off-by: Tiwei Bie <tiwei.btw@antgroup.com>
>>
>> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
>
> Looks fine to me for the version in dev-test branch.
>
> Reviewed-by: Chao Yu <chao@kernel.org>
Yeah, thanks! I will add the tag when applying to -next.
Thanks,
Gao Xiang
>
> Thanks,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-10-12 2:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 11:39 [PATCH] erofs: fix inode metadata space layout description in documentation Tiwei Bie
2023-10-10 12:44 ` Jingbo Xu
2023-10-10 13:06 ` Gao Xiang
2023-10-10 13:39 ` Tiwei Bie
2023-10-12 1:10 ` Chao Yu
2023-10-12 2:01 ` Gao Xiang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox