From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 928BB39FCC6 for ; Thu, 19 Mar 2026 10:53:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773917589; cv=none; b=iy86SHDd3S/I8GjyEvnvmkJ+XBHNc8Jf92yaZ/F8MNzxbdxiXWr0rFCTwXU81Gn/JdBp1DCj3zqHCmHwOglhlRrNl6YD3J5uB4u9BeGbjprysXHt+hGqB4K5Bw8517bxBjlsnW+kXsuARZK+Jl434RtrC52RQX+/l8uD/w5d/zo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773917589; c=relaxed/simple; bh=GRPY48Aa9FpxnnKsJcyzTy/OFANTJJLSsDtZUcY8Z+w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=D6oExDGsVzTT6m+XmwtXKDwxh+4tvsfe+PEKh+enNxJUWvta6tW+AAhoL1+XpkDu5u4mn+5ADhc3AzGpQQh5q/2XUUujcrPj0Q9lQKO0bt9Gy0hPsZwqTrNNgJWQvPpHiSfH75OzSVGvmVLxCIvYHOb/FU2Vj0KEvCAU3qixqZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fyz3w4Pd; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fyz3w4Pd" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-c648bc907ebso443320a12.3 for ; Thu, 19 Mar 2026 03:53:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773917588; x=1774522388; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=P3w6izYfrairSJ55395BwrKF4lapRGrqNyaG/W4OCKE=; b=fyz3w4Pd+Ug3siwCOR4Adz8eOl5axEXvBxQqYDafh9IalJNm3EVgvfdTotxDTf9K6T mzAwAws+zW/TTrMYHDs/WTiIFa6BEXPcJATUbJ1KtJefnISF67YEzTXR457vMq53HjAm 9sngy5AGL+i+1ouOrYm41TkbaIyKCcX0pzgc6hCX6wAoDYW5AW15HThxFqXztLbvJ/xE x38haklgNvMOYmwQtWFPpVA7GAXUAjaOxsiyMVhmhUKYkr/6oPuIbP++dwo3axndMAwm gIB0pStS3iEGINe2afucnlE1YxaV9nSHZufxC+y4rh4pUDozQme4Lkp5Zcrl7CT/1ag1 Y6gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773917588; x=1774522388; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=P3w6izYfrairSJ55395BwrKF4lapRGrqNyaG/W4OCKE=; b=NTVocuHaXhlqu/AlFCwE++t/31F8l2JFIp9Y2WTV7ltTcXtI2HHXZ5yH/E0YtvE7Un rrIYuQ+tBTtJRExqA1lLYezNOXAAkuBztLmkL4SXqbI8K3oNSSvryreuXXnGFkJ1MVRe NPMLngFGW+j3i2gPtquXfI/1Er9hnZnLxAs9JqlaG+xUR7aBeqxcAiDSAqYmrM2CkUC3 93nvteKMxxJJyr5Eau8+rFHvZoe1ZYbx5wWKE/6vzTmB7RiNdiAX+MZPZJ3b2XEJn+z+ qVE+13eA6iMco9d2vW8WBaA7Ze/cr3Iv2UMUVxaavuNhWUJrEeFkm4SRKs4UhsMpzeZx BaeQ== X-Forwarded-Encrypted: i=1; AJvYcCXUdegCmQrUiqd7q3nmaJF0ocLtLD/cnMHcnoyRah6d1NK4yxCh0WJ0SP+lPdbJukwQeglAc7oLJ8zSNho=@vger.kernel.org X-Gm-Message-State: AOJu0YwYC7vLzUIEUJ38pEz2VNXbxT7o7blEmIjSuygjl+MJ7JTif2QH po3LINZ9U5VsHmm6AT4JYUPqj/Z1yUTUs3O1Iyl6bwHjEeCilypBpSMH X-Gm-Gg: ATEYQzxnf6poYhJlbgYTOdPHhHLEzo3pOwr+eXyXiCQf1+ylKr146Csgaf4i8z4vBhf TJPBwbRChMutGPsDGWG2CmwxwsSyPzAN78VpMAbaOqDKnZBC3Jhtke4+7EJxHlhzKrck3/lD8L1 Z/bWLkS3uBMzCOfJ/GU5uWVSh4kNHQu8zwbHYonlHQYGAcyY1LyhiFTuWICKOGsUc2aI6GgssYj n0UgUeqAf7ktUWiSltAuR20VL7N8sn7ncGF60eiOM6vycOVpaOwcX5IQ1FfkB83d/hvh/K2ne/s lTuBmM2mSPUdHJi25xwxKQke/syxPRTg8nj5WV7iJmx7dy0JwnFJP6fkEFApwwYHiZkIxAhM4mw TKliFtMo9tGFFiNGb6uSOfyFNteOT+kdXjNoaJ4lG5kKpxiSN59cC32x+swJJ22dRdRQDbqQYTk ddEaHowfvg323lReH9M/VkUHClchfWLSw= X-Received: by 2002:a05:6a20:6a1a:b0:398:6fd3:7696 with SMTP id adf61e73a8af0-39b9a048bfemr6537821637.59.1773917587866; Thu, 19 Mar 2026 03:53:07 -0700 (PDT) Received: from [192.168.0.106] ([103.216.213.160]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c741e58522csm5653942a12.31.2026.03.19.03.53.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 03:53:06 -0700 (PDT) Message-ID: Date: Thu, 19 Mar 2026 16:23:01 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/11] iio: ad_sigma_delta: replace deprecated iio_push_to_buffers_with_timestamp() To: Jonathan Cameron Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, marcelo.schmitt@analog.com, mazziesaccount@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260316172735.11430-1-atharvd440@gmail.com> <20260316172735.11430-3-atharvd440@gmail.com> <20260316181943.50acd1a3@jic23-huawei> Content-Language: en-US From: Atharv Dubey In-Reply-To: <20260316181943.50acd1a3@jic23-huawei> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Jonathan, On 3/16/26 23:49, Jonathan Cameron wrote: > On Mon, 16 Mar 2026 22:57:27 +0530 > Atharv Dubey wrote: > >> iio_push_to_buffers_with_timestamp() is deprecated. Replace it with >> iio_push_to_buffers_with_ts(), which takes the buffer size as an >> argument and helps avoid potential buffer overflows. >> >> Signed-off-by: Atharv Dubey > Hi Atharv, > > Thank for you for your patch. > > >> --- >> drivers/iio/adc/ad_sigma_delta.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iio/adc/ad_sigma_delta.c b/drivers/iio/adc/ad_sigma_delta.c >> index 7852884703b0..73f3069da987 100644 >> --- a/drivers/iio/adc/ad_sigma_delta.c >> +++ b/drivers/iio/adc/ad_sigma_delta.c >> @@ -636,7 +636,7 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void *p) >> * once, there is no need for sample number tracking. >> */ >> if (sigma_delta->active_slots == 1) { >> - iio_push_to_buffers_with_timestamp(indio_dev, data, pf->timestamp); >> + iio_push_to_buffers_with_ts(indio_dev, data, sizeof(data), pf->timestamp); > What is sizeof(data) and why is that the right value to pass as the new parameter? > >> goto irq_handled; >> } >> >> @@ -662,8 +662,8 @@ static irqreturn_t ad_sd_trigger_handler(int irq, void *p) >> >> if (sigma_delta->current_slot == sigma_delta->active_slots) { >> sigma_delta->current_slot = 0; >> - iio_push_to_buffers_with_timestamp(indio_dev, sigma_delta->samples_buf, >> - pf->timestamp); >> + iio_push_to_buffers_with_ts(indio_dev, sigma_delta->samples_buf, >> + sizeof(sigma_delta->sampkes_buf), pf->timestamp); > Likewise. What value does the new parameter take? > > I'm not going to review any more of this version of the series given these are > both incorrect in the first patch. > > Jonathan You are right, both the fixes are incorrect let me try more on this. I'll send a smaller patch series first and mark it as an RFC. > >> } >> >> irq_handled: > Regards, Atharv