From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com [209.85.167.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B20F537D11E for ; Mon, 11 May 2026 08:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778488031; cv=none; b=auuKAwPmaEJ8ldS+aHw6TcZWaKSNQt2YhA1UMN8JJLtccPhH6loTMST0/yEQSIH1pPawPlfeZ6yA4p74FWxyL6SJoDhkgAr+bFO2mDC2sgFguZu3H7iucgZbTYmki6/p2/p0xOiQW3xK4hm6luDOsoENaIFISqlX73aS/LVYecc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778488031; c=relaxed/simple; bh=ixI1m2JIwigKT9carEcPKDSVR0MMBoicc7KnPcBRpDY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZAwoOV9YRjXmH8P2GHB85lM4hcVZcb8eya7nI4mbZ16InoLLZuQcToYcqZrIhYAsdUpkD30dIVcDcQ/2rzzdfRodTClx18NY+kh3D7cq6S92g4Drp3/lJAVKQwjRQVX7aC6HNNRl6IdP2K100H0zO9wtedlYUoiQt7nLVQl59NA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=foi/ARtf; arc=none smtp.client-ip=209.85.167.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="foi/ARtf" Received: by mail-lf1-f43.google.com with SMTP id 2adb3069b0e04-5a8721851e2so4244474e87.0 for ; Mon, 11 May 2026 01:27:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778488020; x=1779092820; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Df80qNeDPx0rB6WR728JKPLmFNIRxLsod6mvLa2jWdI=; b=foi/ARtfswE08Y++GIhzdHr8fVVnkVqLU5jhcA1BX/NvruiWay5yHic7qBs5/tnsrR wdYyrkkpB26bX2+Ar2RbCvZ+7KfG3yfBMpR2rO4MhHhSKnbcDK7JcxclfrOPhXSIo9wG 1HJLKm+SXys6K9gF/pAR09XhD4lRoqRi4JptpTnLwhAf3Zh+ejPFJiT/FUdH9/lYg0S+ A8XycjZoAKfpjxnY9spSLBC8BnsVTbm6xmsyEA/tyXOFGovskg6nuhxltlOdq7VkbXiv sAeIRp0vXg/Mv7f7DsRBUwhGnU7NQj+tuVa2f6zTgRyNrHJF4L35ltPmonk2vwQR/66s BaIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778488020; x=1779092820; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Df80qNeDPx0rB6WR728JKPLmFNIRxLsod6mvLa2jWdI=; b=XiDYyFCyI2rafhmq/nf8gvlSL/mib5pdX6hDDz9hLtoPsCwN2iUPOogSUMELBweoZK 4oEV3wG+qxdAQGYNM6sJJ70FurWpOaGE52lu9cY8drYtITMn+BmlwcWKkRJW6ey5HSEx MuR7J1X3CPFO5EiIDzK/UVPEFlH4RCWP+rasVjHbwZM8B3gnu3CZslOpPgP+F/vtofDe TqeYXrePuvQYMO0Widu5j2yght78pG97Iyd3t6UP/KhxodMd6hG7FjfRAjgP6CgfxjB1 WTUr8Z14UVFOjkY5Y0XBoN5SwsMp3UiTsjdRuY9o/gMDp3B58PdZWU0fNrvWpz4WhIy2 Xj5w== X-Forwarded-Encrypted: i=1; AFNElJ8z0/2+4s+ROd5LOmf5XbXjTNrW86mFcgLCjJmYwkorhC3d35bfE0qOY5aWEjFvQ97TRjlty9TAjysENPc=@vger.kernel.org X-Gm-Message-State: AOJu0YyALxexkO3m049FlCKQiQ65osPVzE51AkEVMsTxYisK/YPO3mWY l+/qePX5deG+fSwerM3Zi+A+M7C3nE/9Jm7v3IPrG5IwLY6chbBVvljj X-Gm-Gg: Acq92OHzFmbHiQAAd3vxQklud0URllYer7CMGbGv3nV9zLeQPJpJjtZfZvQEpbLsrQU JYtDE3nlrjHJjhOwVJLOo1O4oX4g3V6XqQH8jP1LdVpzKfUTp+OzskPt2UpgustFuhogCi/CowU PFIIcNppZw2ghn/5XHvbdm8xaosVTd1q8QfTZMO9Ev2wAnqIQGaGjGbgIP2mKxkDbnw9w4DsQap jgBcUTDuWTTIfzELxuGQEq6goH7qdvF8cfD+sAURqiqbvb3VN1B90fNmd1Gzt1Yq6QZqGF+M3dj Aow72f9HndV0nfyyuoCBs1eIWpXIrYU28XJAu0exFkqSOV85EKqbMJiCY1OqEL5XrkxlQIu+8q1 t57ZHU2ayL5CrkKIGJYQAPRCukn5yNZjGhXSL3P+9lHR67b6iu0AvJ+mIIhs+fH+LuDY7AYZZ+h EVHXt3l7QTjGoNVlc1wURDr0pYp84sum58ajgoumUTsPITywKkTc4fsq9k9bSM5helUvc4xQyA4 rTzsm2z X-Received: by 2002:a05:6512:33c5:b0:5a8:934d:7cad with SMTP id 2adb3069b0e04-5a8934d7e5bmr7050642e87.20.1778488020149; Mon, 11 May 2026 01:27:00 -0700 (PDT) Received: from ?IPV6:2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703? ([2a10:a5c0:800d:dd00:8fdf:935a:2c85:d703]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-393f60db4fcsm24719271fa.19.2026.05.11.01.26.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 11 May 2026 01:26:59 -0700 (PDT) Message-ID: Date: Mon, 11 May 2026 11:26:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] iio: light: bh1730: Add bh1730 light sensor driver To: Andy Shevchenko , azkali.limited@gmail.com Cc: Jonathan Cameron , David Lechner , =?UTF-8?Q?Nuno_S=C3=A1?= , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , CTCaer , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, heikki.haikola@fi.rohmeurope.com References: <20260511-bh1730-v1-0-e0df1f499135@gmail.com> <20260511-bh1730-v1-2-e0df1f499135@gmail.com> Content-Language: en-US, en-AU, en-GB, en-BW From: Matti Vaittinen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/05/2026 21:20, Andy Shevchenko wrote: > On Sun, May 10, 2026 at 09:18:48PM +0300, Andy Shevchenko wrote: >> On Mon, May 11, 2026 at 01:09:50AM +0700, Alexandre Hamamdjian via B4 Relay wrote: >> >>> Add a driver for the ROHM BH1730FVC ambient light sensor. The device >>> is a 16-bit I2C digital sensor with separate visible and infrared >>> photodiodes, four selectable gains (1x/2x/64x/128x) and a programmable >>> integration time. >>> >>> The driver exposes illuminance via IIO, performs runtime gain and >>> integration-time tracking to keep the ADC in range, and supports >>> optional als-vdd / als-vid regulators. Per-board lux calibration data >>> (integration cycles, lux multiplier, optical-window coefficients, and >>> gain sensitivity coefficients) can be supplied via device tree; >>> sensible defaults are used otherwise. >> >>> +#include >>> +#include >>> +#include >>> +#include >> >>> +#include >> >> Regular drivers do not to be OF-centric. This won't allow them to be used >> outside of OF-only platforms. >> >>> +#include >>> +#include >> >> Missing a lot of headers, follow IWYU. > > ... > >> Here I stop my review and recommend you first to review others' patches and >> learn from other reviews. This will help you a lot with avoiding typical >> mistakes. >> >> Also Matti would be the best reviewer for this as he worked (still works?) >> for ROHM and knows the HW a bit more than average kernel developer. > > Forgot to Cc Matti since I mentioned him. Now done. Thanks for pinging me :) I am not super familiar with this particular sensor - original ROHM driver was written by my colleague Heikki, and not by me. I will anyways take a look and provide what-ever input I can. (I will also CC Heikki just in case, but he may not have the time to look this further. Besides, the email client which can be used with company email isn't really upstream compatible ;) ). -- --- Matti Vaittinen Linux kernel developer at ROHM Semiconductors Oulu Finland ~~ When things go utterly wrong vim users can always type :help! ~~