From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbdG0VAV (ORCPT ); Thu, 27 Jul 2017 17:00:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:55374 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751517AbdG0VAS (ORCPT ); Thu, 27 Jul 2017 17:00:18 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 41D4960AA1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Subject: Re: [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios To: Vivek Gautam , bjorn.andersson@linaro.org, linus.walleij@linaro.org, robh+dt@kernel.org, andy.gross@linaro.org, linux-arm-msm@vger.kernel.org Cc: rnayak@codeaurora.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1501137036-20155-1-git-send-email-vivek.gautam@codeaurora.org> <1501137036-20155-2-git-send-email-vivek.gautam@codeaurora.org> From: Stephen Boyd Message-ID: Date: Thu, 27 Jul 2017 14:00:15 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501137036-20155-2-git-send-email-vivek.gautam@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/26/2017 11:30 PM, Vivek Gautam wrote: > Signed-off-by: Vivek Gautam > --- > arch/arm64/boot/dts/qcom/pmi8994.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > index d3879a4e8076..3b04ca63c31e 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi > @@ -8,6 +8,23 @@ > reg = <0x2 SPMI_USID>; > #address-cells = <1>; > #size-cells = <0>; > + > + pmi8994_gpios: gpios@c000 { > + compatible = "qcom,pmi8994-gpio"; Please also include the generic "qcom,spmi-gpio" compatible. We really don't need to add the "qcom,pmi8994-gpio" one to the driver right now so I would leave that out of the driver but leave it here in the dtsi file of course. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project