From: Florian Fainelli <f.fainelli@gmail.com>
To: Colin Foster <colin.foster@in-advantage.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Cc: Vladimir Oltean <vladimir.oltean@nxp.com>,
Claudiu Manoil <claudiu.manoil@nxp.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH v5 net-next 2/4] net: dsa: ocelot: felix: Remove requirement for PCS in felix devices
Date: Tue, 7 Dec 2021 16:41:33 -0800 [thread overview]
Message-ID: <f0c5ade2-65f0-17b9-7d12-7136a037aa75@gmail.com> (raw)
In-Reply-To: <20211207170030.1406601-3-colin.foster@in-advantage.com>
On 12/7/21 9:00 AM, Colin Foster wrote:
> Existing felix devices all have an initialized pcs array. Future devices
> might not, so running a NULL check on the array before dereferencing it
> will allow those future drivers to not crash at this point
>
> Signed-off-by: Colin Foster <colin.foster@in-advantage.com>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
next prev parent reply other threads:[~2021-12-08 0:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-07 17:00 [PATCH v5 net-next 0/4] prepare ocelot for external interface control Colin Foster
2021-12-07 17:00 ` [PATCH v5 net-next 1/4] net: dsa: ocelot: remove unnecessary pci_bar variables Colin Foster
2021-12-07 17:00 ` [PATCH v5 net-next 2/4] net: dsa: ocelot: felix: Remove requirement for PCS in felix devices Colin Foster
2021-12-08 0:41 ` Florian Fainelli [this message]
2021-12-07 17:00 ` [PATCH v5 net-next 3/4] net: dsa: ocelot: felix: add interface for custom regmaps Colin Foster
2021-12-08 0:42 ` Florian Fainelli
2021-12-07 17:00 ` [PATCH v5 net-next 4/4] net: mscc: ocelot: split register definitions to a separate file Colin Foster
2021-12-08 0:44 ` Florian Fainelli
2021-12-08 6:00 ` [PATCH v5 net-next 0/4] prepare ocelot for external interface control patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0c5ade2-65f0-17b9-7d12-7136a037aa75@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox