From: Ishraq Ibne Ashraf <ishraq.i.ashraf@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, himanshujha199640@gmail.com,
goudapatilk@gmail.com, insafonov@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [PATCH 2/2] staging: rtl8188eu: Fix private WEXT IOCTL calls
Date: Sun, 26 Nov 2017 01:45:59 +0100 [thread overview]
Message-ID: <f0db443d-c9cb-e751-914c-163e76d1f29d@gmail.com> (raw)
In-Reply-To: <20171125044014.lfdwsrfgl4dz725d@mwanda>
Hi,
What was broken was private/device specific IOCTL calls implemented by this driver. The standard IOCTL calls worked and the driver worked as it was in client mode.
But in AP mode with hostapd (https://w1.fi/hostapd/) the rtl871xdrv driver of hostapd (which is required for using devices that use this driver in AP mode) invokes private/device specific IOCTL calls and in the existing driver they could only be invoked through the ndo_do_ioctl interface of the driver. Support for which was removed in the mentioned commit by Johannes Berg. Hence the driver stopped working in AP mode with hostapd using rtl871xdrv driver.
The solution was to implement equivalent versions of the existing private/device specific IOCTLs which will be invoked by the iw_handler_def interface.
Cheers,
Ishraq
On 11/25/2017 05:40 AM, Dan Carpenter wrote:
> I added Johannes to the CC list again because this is sort of his
> fault... To be honest, I'm a little bit puzzled. I would have thought
> Johannes's change would have made some code unused and that we could
> delete it now. I haven't looked at this.
next prev parent reply other threads:[~2017-11-26 0:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 1:29 [PATCH] staging: rtl8188eu: Fix private WEXT IOCTL calls ishraq.i.ashraf
2017-11-23 13:24 ` Dan Carpenter
2017-11-25 0:52 ` [PATCH 2/2] " ishraq.i.ashraf
2017-11-25 4:40 ` Dan Carpenter
2017-11-25 18:12 ` Ishraq Ibne Ashraf
2017-11-26 0:45 ` Ishraq Ibne Ashraf [this message]
2017-11-27 11:33 ` Johannes Berg
2017-11-25 1:29 ` [PATCH v2] " ishraq.i.ashraf
2017-11-25 4:55 ` Dan Carpenter
2017-11-25 18:29 ` [PATCH v3] " ishraq.i.ashraf
2017-11-25 21:25 ` Dan Carpenter
2017-11-27 11:24 ` Johannes Berg
2017-11-28 8:00 ` [PATCH] staging: rtl8188eu: fix kzalloc-simple.cocci warnings kbuild test robot
2017-11-28 8:00 ` [PATCH v3] staging: rtl8188eu: Fix private WEXT IOCTL calls kbuild test robot
2017-12-04 15:20 ` kbuild test robot
2017-11-26 20:45 ` [PATCH] " kbuild test robot
2017-11-26 23:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0db443d-c9cb-e751-914c-163e76d1f29d@gmail.com \
--to=ishraq.i.ashraf@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=goudapatilk@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=insafonov@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox