From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 224AA1DDA09 for ; Tue, 28 Jan 2025 23:03:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738105392; cv=none; b=m8A92uMZsZS6XkKTrrpZEWLf6YuPCD0kW9quNxR2fmoDOVNEnNP1BGcK8TkVjwuIEcmOCJ66n1wDFVY01J6GVkrA0F5iriW3jr+qebvR/mXcShVezLAkK8wfeS/kqxgbLu+T4g9yvFwURHHuVdKVzXel00K9UyX4nN2jtZWiH28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738105392; c=relaxed/simple; bh=/EAxo+FiqTJQD3j+vVs/MHYnU1ZqIZPGB9C+tQcQfs0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l9nNXNg/tXpNPsrG1n9r4CelaLr3iaOSO17ThwxTKkqB0E6qxECVWKB4+XsNzOu95G3v8yfXx56cSkfDYgqHxPxhZ3UhgxNw3Yi6FuhzRH8+LkPEgN/KHvyEsll6WH3jJagznnhOglbZBMwCMv4rPhbEtaab56Shw4u9RBTBJ78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=uRSzQLKO; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="uRSzQLKO" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1738105389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WnJRkvRrb5lrPsTYQXDZXAjjTMS0jVj7cVr6R2qq15k=; b=uRSzQLKOsqbFZGi3UU5T/sVGXbQgJu0fH2bOvTiesw4L50O9eNWX/6EuIBllutUkiO3h0w TDMra5ugWePCU65hB03Ed3sDmvoLzqDTzkFua44uiuNZ6dweKguIjJnaWf+oNUOTvwUPCx 6qmb2SeoT1SftGAlYv3y6muC/Q6Ro24= Date: Tue, 28 Jan 2025 15:03:01 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next v3 12/14] selftests/bpf: test_xdp_veth: Add XDP broadcast redirection tests To: "Bastien Curutchet (eBPF Foundation)" Cc: Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , Alexis Lothore , Thomas Petazzoni , netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250128-redirect-multi-v3-0-c1ce69997c01@bootlin.com> <20250128-redirect-multi-v3-12-c1ce69997c01@bootlin.com> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Martin KaFai Lau In-Reply-To: <20250128-redirect-multi-v3-12-c1ce69997c01@bootlin.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 1/28/25 1:57 AM, Bastien Curutchet (eBPF Foundation) wrote: > Set the tests to run serially to avoid conflicts with > test_xdp_veth_redirect I think this has been fixed in v3? Others lgtm also. Thanks for working on this. > +void test_xdp_veth_broadcast_redirect(void) > +{ > + if (test__start_subtest("0/BROADCAST")) > + xdp_veth_broadcast_redirect(0, BPF_F_BROADCAST); > + > + if (test__start_subtest("0/(BROADCAST | EXCLUDE_INGRESS)")) > + xdp_veth_broadcast_redirect(0, BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS); > + > + if (test__start_subtest("DRV_MODE/BROADCAST")) > + xdp_veth_broadcast_redirect(XDP_FLAGS_DRV_MODE, BPF_F_BROADCAST); > + > + if (test__start_subtest("DRV_MODE/(BROADCAST | EXCLUDE_INGRESS)")) > + xdp_veth_broadcast_redirect(XDP_FLAGS_DRV_MODE, > + BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS); > + > + if (test__start_subtest("SKB_MODE/BROADCAST")) > + xdp_veth_broadcast_redirect(XDP_FLAGS_SKB_MODE, BPF_F_BROADCAST); > + > + if (test__start_subtest("SKB_MODE/(BROADCAST | EXCLUDE_INGRESS)")) > + xdp_veth_broadcast_redirect(XDP_FLAGS_SKB_MODE, > + BPF_F_BROADCAST | BPF_F_EXCLUDE_INGRESS); > +}