Re: [PATCH v4 1/4] mtd: spi-nor: add OTP support

[<Tudor.Ambarus@microchip.com>]

On 3/15/21 11:39 AM, Tudor Ambarus - M18064 wrote:
> On 3/15/21 11:23 AM, Michael Walle wrote:
> 
> cut
> 
>>>> diff --git a/drivers/mtd/spi-nor/otp.c b/drivers/mtd/spi-nor/otp.c
>>>> new file mode 100644
>>>> index 000000000000..4e301fd5156b
>>>> --- /dev/null
>>>> +++ b/drivers/mtd/spi-nor/otp.c
>>>> @@ -0,0 +1,218 @@
>>>> +// SPDX-License-Identifier: GPL-2.0
>>>> +/*
>>>> + * OTP support for SPI NOR flashes
>>>> + *
>>>> + * Copyright (C) 2021 Michael Walle <michael@walle.cc>> + */
>>>> +
>>>> +#include <linux/log2.h>
>>>> +#include <linux/mtd/mtd.h>
>>>> +#include <linux/mtd/spi-nor.h>
>>>> +
>>>> +#include "core.h"
>>>> +
>>>> +#define spi_nor_otp_ops(nor) ((nor)->params->otp.ops)
>>>> +#define spi_nor_otp_region_len(nor) ((nor)->params->otp.org->len)
>>>> +#define spi_nor_otp_n_regions(nor)
>>>> ((nor)->params->otp.org->n_regions)
>>>
>>> I don't like these wrappers because they gratuiously hide what's really
>>> there.
>>> I find the code more easier to read without these wrappers, because I
>>> don't
>>> have to memorize what these wrappers are doing, and I better see how
>>> the code
>>> is organized.
>>
>> TBH I find it easier on the eye and I've never seen so much dereferences
>> as in mtd/spi-nor.

the dereferences will still be there, but will be just hidden by these wrappers,
don't they? Why would one prefer the wrappers?

> 
> It's what I prefer, but it's not a hard requirement. Would you please check
> for a second opinion with Vignesh? Inquire about the helpers too. Then do as
> you find best.
> 
> Cheers,
> ta
>