From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
To: Vincent Legoll <vincent.legoll@gmail.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all
Date: Fri, 15 Dec 2017 13:23:37 -0500 [thread overview]
Message-ID: <f1007c70-caa4-8ca9-3d52-532e4302cc6e@gmail.com> (raw)
In-Reply-To: <CAEwRq=qeVDDCY+TFcbF0aeYWLzx0f-256=kwXTZbyEAkNRgUHA@mail.gmail.com>
On 2017-12-15 12:24, Vincent Legoll wrote:
> Hello,
>
>>> This looks fine to me. Ard?
>>
>> Doesn't this break existing configs?
>
> Would adding a "default yes" on the new menuconfig be OK.
>
> If yes, I'd respin it for a v2
>
Alternatively, would it not make some degree of sense to just turn the
CONFIG_EFI symbol into the menuconfig? It already controls all the EFI
related stuff except GPT support (which should not be dependent on EFI
support), so anyone who wants EFI support already has it enabled, and it
would be a bit nicer to work with when actually configuring a kernel (It
is rather annoying to have to effectively enable something twice).
The same (in theory) goes for pretty much any other patch like this
where there's already a config option controlling it all that just isn't
a menuconfig.
next prev parent reply other threads:[~2017-12-15 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-09 15:52 [PATCH] efi: make EFI a menuconfig to ease disabling it all Vincent Legoll
2017-12-15 15:19 ` Matt Fleming
2017-12-15 16:50 ` Ard Biesheuvel
2017-12-15 17:24 ` Vincent Legoll
2017-12-15 18:23 ` Austin S. Hemmelgarn [this message]
2017-12-16 10:46 ` [PATCH,v2] " Vincent Legoll
2017-12-16 10:46 ` [PATCH] " Vincent Legoll
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1007c70-caa4-8ca9-3d52-532e4302cc6e@gmail.com \
--to=ahferroin7@gmail.com \
--cc=anton@enomsg.org \
--cc=ard.biesheuvel@linaro.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=tony.luck@intel.com \
--cc=vincent.legoll@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox