From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932130AbdLOSXv (ORCPT <rfc822;w@1wt.eu>);
        Fri, 15 Dec 2017 13:23:51 -0500
Received: from mail-it0-f66.google.com ([209.85.214.66]:37509 "EHLO
        mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756090AbdLOSXn (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 15 Dec 2017 13:23:43 -0500
X-Google-Smtp-Source: ACJfBovf9RXtlagmGhzaozsALfHmXvC2uyE0FRJ0pSr3tFaHP/wyasSwE3tvtH0rQJO+DjYAJlquRA==
Subject: Re: [PATCH] efi: make EFI a menuconfig to ease disabling it all
To: Vincent Legoll <vincent.legoll@gmail.com>,
        Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
        Kees Cook <keescook@chromium.org>, Anton Vorontsov <anton@enomsg.org>,
        Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
        "linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20171209155252.6403-1-vincent.legoll@gmail.com>
 <20171215151910.GC3204@codeblueprint.co.uk>
 <CAKv+Gu8Jd8Z78_1SrcLvX7DKSxf9BjkJtJ+UXYi7ak_zpA3fKQ@mail.gmail.com>
 <CAEwRq=qeVDDCY+TFcbF0aeYWLzx0f-256=kwXTZbyEAkNRgUHA@mail.gmail.com>
From: "Austin S. Hemmelgarn" <ahferroin7@gmail.com>
Message-ID: <f1007c70-caa4-8ca9-3d52-532e4302cc6e@gmail.com>
Date: Fri, 15 Dec 2017 13:23:37 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <CAEwRq=qeVDDCY+TFcbF0aeYWLzx0f-256=kwXTZbyEAkNRgUHA@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2017-12-15 12:24, Vincent Legoll wrote:
> Hello,
> 
>>> This looks fine to me. Ard?
>>
>> Doesn't this break existing configs?
> 
> Would adding a "default yes" on the new menuconfig be OK.
> 
> If yes, I'd respin it for a v2
> 
Alternatively, would it not make some degree of sense to just turn the 
CONFIG_EFI symbol into the menuconfig?  It already controls all the EFI 
related stuff except GPT support (which should not be dependent on EFI 
support), so anyone who wants EFI support already has it enabled, and it 
would be a bit nicer to work with when actually configuring a kernel (It 
is rather annoying to have to effectively enable something twice).

The same (in theory) goes for pretty much any other patch like this 
where there's already a config option controlling it all that just isn't 
a menuconfig.