From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "David E. Box" <david.e.box@linux.intel.com>
Cc: rajvi.jingar@linux.intel.com,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>
Subject: Re: [PATCH 1/3] platform/x86/intel/vsec: Remove nuisance message
Date: Mon, 26 Feb 2024 16:54:35 +0200 (EET) [thread overview]
Message-ID: <f10d8775-ce3f-d241-8d37-a2b1c5b1eb85@linux.intel.com> (raw)
In-Reply-To: <20240221211204.515159-1-david.e.box@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1122 bytes --]
On Wed, 21 Feb 2024, David E. Box wrote:
> intel_vsec_walk_header() is used to configure features from devices that
> don't provide a PCI VSEC or DVSEC structure. Some of these features may
> be unsupported and fail to load. Ignore them silently as we do for
> unsupported features described by VSEC/DVSEC.
>
> Signed-off-by: David E. Box <david.e.box@linux.intel.com>
> ---
> drivers/platform/x86/intel/vsec.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/intel/vsec.c b/drivers/platform/x86/intel/vsec.c
> index 778eb0aa3479..0fdfaf3a4f5c 100644
> --- a/drivers/platform/x86/intel/vsec.c
> +++ b/drivers/platform/x86/intel/vsec.c
> @@ -236,10 +236,7 @@ static bool intel_vsec_walk_header(struct pci_dev *pdev,
>
> for ( ; *header; header++) {
> ret = intel_vsec_add_dev(pdev, *header, info);
> - if (ret)
> - dev_info(&pdev->dev, "Could not add device for VSEC id %d\n",
> - (*header)->id);
> - else
> + if (!ret)
> have_devices = true;
> }
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
--
i.
prev parent reply other threads:[~2024-02-26 14:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 21:12 [PATCH 1/3] platform/x86/intel/vsec: Remove nuisance message David E. Box
2024-02-21 21:12 ` [PATCH 2/3] platform/x86/intel/pmc/lnl: Remove SSRAM support David E. Box
2024-02-23 3:06 ` Kuppuswamy Sathyanarayanan
2024-02-26 15:03 ` Ilpo Järvinen
2024-02-21 21:12 ` [PATCH 3/3] platform/x86/intel/pmc/arl: Put GNA device in D3 David E. Box
2024-02-23 3:09 ` Kuppuswamy Sathyanarayanan
2024-02-26 15:01 ` Ilpo Järvinen
2024-02-23 3:02 ` [PATCH 1/3] platform/x86/intel/vsec: Remove nuisance message Kuppuswamy Sathyanarayanan
2024-02-26 14:54 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f10d8775-ce3f-d241-8d37-a2b1c5b1eb85@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=david.e.box@linux.intel.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rajvi.jingar@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox