From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A90C3DA53 for ; Thu, 17 Aug 2023 16:05:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353447AbjHQQFT (ORCPT ); Thu, 17 Aug 2023 12:05:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353448AbjHQQE5 (ORCPT ); Thu, 17 Aug 2023 12:04:57 -0400 Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8170430F5 for ; Thu, 17 Aug 2023 09:04:56 -0700 (PDT) Received: from eig-obgw-5004a.ext.cloudfilter.net ([10.0.29.221]) by cmsmtp with ESMTP id WZeoqWCG9WU1cWfUVqF2au; Thu, 17 Aug 2023 16:04:55 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id WfUUqU76zD5qiWfUUqPCWr; Thu, 17 Aug 2023 16:04:55 +0000 X-Authority-Analysis: v=2.4 cv=dMe1JcVb c=1 sm=1 tr=0 ts=64de4527 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=WzbPXH4gqzPVN0x6HrNMNA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=UttIx32zK-AA:10 a=wYkD_t78qR0A:10 a=VwQbUJbxAAAA:8 a=OcNJt-qWwfHZ17eyJIQA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZA1JnYm2sizdw4HAoCpwZQIm3d+6duiDWNO2aTXtz+s=; b=tAIGDQtxZ2k7asM3pp0AyIqJFG ElYb3DfGINfI30f1NWoS43/Q2kA5LnL7npPiggmeAI9cjBcMqlHJKQF5y2/UlfN35IIXRyLXgq5zs L52QaFfnykiBoAi3ztaoC2jII8416FhRhiIzch9vPcQtXk1Wd+v6kq+ULedY3mut9sM3KWwSjV+Jx mVzWg9gcw26/2tK7lbw+cOg+Jk5pyL5xsAhEtjD4hfPL6EYjrHMyQnHxoeAq1n5T3OXck5M487rxO p/MEntWaNpBganNWLSFtpSzELFaOQ27b9rX/9WQ2q+VOp6yxpoepN1Znw/tSZRJrS+gLMjrnsrWjb a66BZ2MQ==; Received: from 187-162-21-192.static.axtel.net ([187.162.21.192]:57282 helo=[192.168.15.8]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qWfUU-001S6c-0Q; Thu, 17 Aug 2023 11:04:54 -0500 Message-ID: Date: Thu, 17 Aug 2023 10:05:52 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: struct_size() using sizeof() vs offsetof() Content-Language: en-US To: Alejandro Colomar , Kees Cook , "Gustavo A. R. Silva" Cc: LKML , linux-hardening@vger.kernel.org References: <74e8cf91-d095-33e3-c548-34d80b691089@kernel.org> <202308161913.91369D4A@keescook> <09b4a2ce-da74-3a19-6961-67883f634d98@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <09b4a2ce-da74-3a19-6961-67883f634d98@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 187.162.21.192 X-Source-L: No X-Exim-ID: 1qWfUU-001S6c-0Q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 187-162-21-192.static.axtel.net ([192.168.15.8]) [187.162.21.192]:57282 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 2 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN6iKVzLRaXmdLinVdSkzfm8UN9b7HDnWyEGbORQJDMKYM0i4m5X2FNKABNKkBEqPecH58Pz0Q+h2SSUrKK1fHwxhTw5nS1zVuFX143iqh6dM4gRMq1/ uElRzR1ol4DwGMOxyC4zYNcebaxJUzgitgEYFLYiYmuaubnLqmnlw2Lf32WLg0ONrwf9Ql3LlHZHCkEYjt4XnFoeu/aOTzVKRcj2NahndVk8t/7MgFYr7LYC Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - tp_c = kzalloc(sizeof(*tp_c), GFP_KERNEL); > + tp_c = kzalloc(struct_size(tp_c, hlist->ht, 1), GFP_KERNEL); I just sent a fix[1]. Thanks for reporting this! :) -- Gustavo [1] https://lore.kernel.org/linux-hardening/ZN5DvRyq6JNz20l1@work/