Re: [PATCH v1 1/3] dt-bindings: mmc: Drop unused properties

Conor Dooley
2023-08-30T19:05:24Z

[-- Attachment #1: Type: text/plain, Size: 2002 bytes --]

On Wed, Aug 30, 2023 at 11:18:44AM +0800, William Qiu wrote:
> Due to the change of tuning implementation, it's no longer necessary to
> use the "starfive,sysreg" property in dts, so drop the relevant
> description in dt-bindings here.

How does changing your software implantation invalidate a description of
the hardware?

>
> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
> ---
> .../bindings/mmc/starfive,jh7110-mmc.yaml | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> index 51e1b04e799f..10df41941331 100644
> --- a/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/starfive,jh7110-mmc.yaml
> @@ -36,26 +36,12 @@ properties:
> interrupts:
> maxItems: 1
>
> - starfive,sysreg:
> - $ref: /schemas/types.yaml#/definitions/phandle-array
> - items:
> - - items:
> - - description: phandle to System Register Controller syscon node
> - - description: offset of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> - - description: shift of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> - - description: mask of SYS_SYSCONSAIF__SYSCFG register for MMC controller
> - description:
> - Should be four parameters, the phandle to System Register Controller
> - syscon node and the offset/shift/mask of SYS_SYSCONSAIF__SYSCFG register
> - for MMC controller.
> -
> required:
> - compatible
> - reg
> - clocks
> - clock-names
> - interrupts
> - - starfive,sysreg
>
> unevaluatedProperties: false
>
> @@ -73,5 +59,4 @@ examples:
> fifo-depth = <32>;
> fifo-watermark-aligned;
> data-addr = <0>;
> - starfive,sysreg = <&sys_syscon 0x14 0x1a 0x7c000000>;
> };
> --
> 2.34.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]