From: John Hubbard <jhubbard@nvidia.com>
To: Danilo Krummrich <dakr@kernel.org>,
Cheng-Yang Chou <yphbchou0911@gmail.com>
Cc: Alice Ryhl <aliceryhl@google.com>,
Alexandre Courbot <acourbot@nvidia.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Gary Guo <gary@garyguo.net>,
nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, jserv@ccns.ncku.edu.tw
Subject: Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention
Date: Thu, 12 Mar 2026 12:21:53 -0700 [thread overview]
Message-ID: <f1398086-ff75-42c8-ad43-97077dd22267@nvidia.com> (raw)
In-Reply-To: <DH11MBCZFQIJ.33U3GFVI1HFZF@kernel.org>
On 3/12/26 12:16 PM, Danilo Krummrich wrote:
> On Thu Mar 12, 2026 at 7:45 PM CET, Cheng-Yang Chou wrote:
...
>> Would that work for you?
>
> I think the module name should ideally match the directoy name, i.e. we have
>
> drivers/gpu/nova-core/
>
> with the module name "nova-core" and
>
> drivers/gpu/drm/nova/
>
> with the module name "nova-drm".
When p
When people do things like lsmod(1), they don't see the directory
path for the module source code, so if the name doesn't include
drm, then no one knows that "nova" implies "nova-drm".
On the other hand, I was OK with just explaining to people that "nova"
is the upper layer kernel module, and that it's the one that does
DRM things.
Which is why I'm merely "OK" with the name change, as opposed to
thinking that it's required.
>
> The reason why this is not .../nova-drm/ already is that I figured it would be a
> bit redundant given that "drm" is already part of the path.
>
> While I don't mind changing this, I wonder what this would mean for the
> Kconfig, CONFIG_DRM_NOVA_DRM? :)
I also worry that we might not have enough DRM's in that
CONFIG item. haha :)
thanks,
--
John Hubbard
next prev parent reply other threads:[~2026-03-12 19:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 6:24 [PATCH] gpu: nova: rename drivers to use kebab-case convention Cheng-Yang Chou
2026-03-10 20:41 ` Timur Tabi
2026-03-11 1:34 ` John Hubbard
2026-03-12 18:45 ` Cheng-Yang Chou
2026-03-12 18:54 ` John Hubbard
2026-03-12 19:16 ` Danilo Krummrich
2026-03-12 19:21 ` John Hubbard [this message]
2026-03-12 19:48 ` Danilo Krummrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1398086-ff75-42c8-ad43-97077dd22267@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=acourbot@nvidia.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gary@garyguo.net \
--cc=jserv@ccns.ncku.edu.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=simona@ffwll.ch \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox