From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=13.77.154.182 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794965377; b=cuOKGwucOTdwDgeG+uIV4QuEuBzaUY0YDe1o6xBsLH71024uiHGS4AS5NJKouDnommQf TiOwsfHigqxVXLy+KVzMyvlyNwU/wQbWC0+52j1fP4RQp9BqX5FHO9qId3aHkTck9J59n XUgUaU/inMcnFhICIGp3ViOB603lchYze+SQP4P9HsvnAmPiMcgVhi6xrOoUz0oOkZhpq zPkC9eg6Ns90ouZcUuvu8BkXCKyrFaKgD31sl3OxFI5bxFevpZBJPGIkuSuCBNyTCpw7k b2s6lQ7Hxe6pkLFKrozligfGAMt/h4+GMcyAfpep8EeYZ5hSye84yEkXHqOyDufa0rQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794965377; h=DMARC-Filter:Received:DKIM-Filter:DKIM-Signature:Message-ID:Date: MIME-Version:User-Agent:Subject:Content-Language:From:To:Cc: References:In-Reply-To:Content-Type:Content-Transfer-Encoding: X-Spam-Status:X-Spam-Checker-Version; bh=En2HFkVRz7jUndIJWs1vjfMzW7QUrXLJFOywq7zEjgM=; b=IQw2TnsrzLC8qWN+38jzfH18yXnorHAHTHwbInc/XEN8K8xxDskl2TcFUrL4CtFmkEh9 luT1SV560VdR7IJrHUMuz0WLDm1g8LV9335RMpQw1XkdGadetlvjB1KuyRMMedAUBJQnE tM8+hpXlHdOL4lO7KL4IAK3UVwf5CsCRRAyjccG5cy7rhrk2zkREYuETvuv7cptD4dMf1 8hhLYMsWW4+9dhUB7Ywv8+kD3gg0giwsqnl8U5FQ73LcFPRftNzEscN0YzVdxKDEmsekT IeKlyfJUYnu3swNS6Yqzwf8HGUzb3ZY+yjjd+SvO6ZO0lhFX6AwLFHXevX7mr9W+eAg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.microsoft.com; spf=pass smtp.mailfrom=linux.microsoft.com; dkim=pass header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b=jxgQrE+5; arc=none smtp.remote-ip=13.77.154.182 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9C09A606A891; Wed, 18 Nov 2026 01:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 9C09A606A891 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.microsoft.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.a=rsa-sha256 header.s=default header.b=jxgQrE+5 Received: from [192.168.0.88] (192-184-212-33.fiber.dynamic.sonic.net [192.184.212.33]) by linux.microsoft.com (Postfix) with ESMTPSA id B292620B7169; Tue, 17 Nov 2026 17:29:34 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com B292620B7169 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1794965375; bh=En2HFkVRz7jUndIJWs1vjfMzW7QUrXLJFOywq7zEjgM=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=jxgQrE+5/+IOWBmij56qJv+Q2l5X0GuaotxyKD2Gfuk04WROOvvx4dIY6ORHw/sMG IcQB2mHFqf5nkMayKL0Rx+z5gAvYLhaWns+WHpxm4EShE4HNXIUfgNY/adszgUx3h6 kVjufo8h4+/Ztb9gA9rLNYY44ETfakE+9+dKPEoA= Message-ID: Date: Tue, 17 Nov 2026 17:29:34 -0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.1 Subject: Re: [PATCH v6 4/6] Drivers: hv: Mark shared memory as decrypted for CCA Realms Content-Language: en-US From: Mukesh R To: Kameron Carr Cc: Michael Kelley , "decui@microsoft.com" , "haiyangz@microsoft.com" , "wei.liu@kernel.org" , "arnd@arndb.de" , "catalin.marinas@arm.com" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-hyperv@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lpieralisi@kernel.org" , "mark.rutland@arm.com" , "sudeep.holla@kernel.org" , "thuth@redhat.com" , "will@kernel.org" References: <20261031001412.4150488-1-kameroncarr@linux.microsoft.com> <20261031001412.4150488-5-kameroncarr@linux.microsoft.com> <7ebf7187-bf42-fc11-e89b-b1aba96539d2@linux.microsoft.com> <5fddb57c-8805-4fbd-9e27-1c8654f29436@linux.microsoft.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 11/17/26 11:57, Mukesh R wrote: > On 11/16/26 11:53, Kameron Carr wrote: >> On 11/13/2026 6:59 PM, Mukesh R wrote: >>> On 11/12/26 16:46, Mukesh R wrote: >>>> On 11/12/26 09:49, Kameron Carr wrote: >>>>> On 11/11/2026 6:43 PM, Mukesh R wrote: >>>>>> On 11/11/26 10:01, Michael Kelley wrote: >>>>>>> From: Kameron Carr Sent: Friday, October 30, 2026 5:14 PM >>>>>>>> >>>>>>>> In hv_common_cpu_init(), the per-CPU hypercall input/output pages need >>>>>>>> to be marked as decrypted (shared) for confidential VM isolation types. >>>>>>>> This is already done for SNP and TDX isolation; extend the same handling >>>>>>>> to Arm CCA Realm guests so that the host hypervisor can access the >>>>>>>> shared hypercall buffers. >>>>>>>> >>>>>>>> is_realm_world() is declared in include/linux/arm-rsi-cmds.h which only >>>>>>>> builds on arm64 (it includes ), so using it directly in >>>>>>>> the arch-neutral drivers/hv/hv_common.c would break the x86 build. >>>>>>>> Introduce a Hyper-V-specific helper following the established >>>>>>>> hv_isolation_type_snp() / hv_isolation_type_tdx() pattern. >>>>>>>> >>>>>>>> On architectures other than arm64 the weak default keeps the existing >>>>>>>> behaviour. >>>>>>>> >>>>>>>> Reviewed-by: Michael Kelley >>>>>>>> Signed-off-by: Kameron Carr >>>>>>>> --- >>>>>>>>     arch/arm64/hyperv/mshyperv.c   |  5 +++++ >>>>>>>>     drivers/hv/hv_common.c         | 17 +++++++++++++---- >>>>>>>>     include/asm-generic/mshyperv.h |  1 + >>>>>>>>     3 files changed, 19 insertions(+), 4 deletions(-) >>>>>>>> >>>>>>>> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c >>>>>>>> index 46ab2da..da6c3aa0 100644 >>>>>>>> --- a/arch/arm64/hyperv/mshyperv.c >>>>>>>> +++ b/arch/arm64/hyperv/mshyperv.c >>>>>>>> @@ -182,3 +182,8 @@ bool hv_is_hyperv_initialized(void) >>>>>>>>         return hyperv_initialized; >>>>>>>>     } >>>>>>>>     EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized); >>>>>>>> + >>>>>>>> +bool hv_isolation_type_cca(void) >>>>>>>> +{ >>>>>>>> +    return is_realm_world(); >>>>>>>> +} >>>>>>>> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c >>>>>>>> index 31256cb..a60c92c 100644 >>>>>>>> --- a/drivers/hv/hv_common.c >>>>>>>> +++ b/drivers/hv/hv_common.c >>>>>>>> @@ -476,6 +476,7 @@ int hv_common_cpu_init(unsigned int cpu) >>>>>>>>         u64 msr_vp_index; >>>>>>>>         gfp_t flags; >>>>>>>>         const int pgcount = hv_output_page_exists() ? 2 : 1; >>>>>>>> +    const size_t alloc_size = ALIGN((size_t)pgcount * HV_HYP_PAGE_SIZE, PAGE_SIZE); >>>>>>>>         void *mem; >>>>>>>>         int ret = 0; >>>>>>>> >>>>>>>> @@ -489,7 +490,7 @@ int hv_common_cpu_init(unsigned int cpu) >>>>>>>>          * online and then taken offline >>>>>>>>          */ >>>>>>>>         if (!*inputarg) { >>>>>>>> -        mem = kmalloc_array(pgcount, HV_HYP_PAGE_SIZE, flags); >>>>>>>> +        mem = kmalloc(alloc_size, flags); >>>>>>>>             if (!mem) >>>>>>>>                 return -ENOMEM; >>>>>>>> >>>>>>>> @@ -499,14 +500,16 @@ int hv_common_cpu_init(unsigned int cpu) >>>>>>>>             } >>>>>>>> >>>>>>>>             if (!ms_hyperv.paravisor_present && >>>>>>>> -            (hv_isolation_type_snp() || hv_isolation_type_tdx())) { >>>>>>>> -            ret = set_memory_decrypted((unsigned long)mem, pgcount); >>>>>>>> +            (hv_isolation_type_snp() || hv_isolation_type_tdx() || >>>>>>>> +             hv_isolation_type_cca())) { >>>>>>> >>>>>>> Could this big "if" statement use "hv_is_isolation_supported()" instead >>>>>>> of explicitly testing for each CoCo VM type? I ask partly because >>>>>>> Mukesh Rathor has just submitted a patch [1] that introduces a new >>>>>>> function that does something almost exactly the same as >>>>>>> hv_is_isolation_supported() and uses it here. >>>>>> >>>>>>>> +            (hv_isolation_type_snp() || hv_isolation_type_tdx() || >>>>>>>> +             hv_isolation_type_cca())) { >>>>>> >>>>>> With my change, this will become: >>>>>> >>>>>>           (hv_isolation_hw_cvm() || hv_isolation_type_cca())) { >>>>> >>>>> Any reason you wouldn't change hv_isolation_hw_cvm() to >>>>> >>>>>     return hv_isolation_type_snp() || hv_isolation_type_tdx() || >>>>>       hv_isolation_type_cca() >>>>> >>>>> That would seem more logical to me. >>>>> >>>> >>>> We could, I just don't know if on cca, the repeat hypercall has same >>>> behavior. I was leaving that for the arm team. Anyways, I sent question >>>> to the hyp team, if they say yes, i can update my patch to include that. >>>> >>>> Thanks, >>>> -Mukesh >>> >>> >>> Confirming, arm has same behavior and needs the fix also. So, we can def >>> expand the check to include _cca. >>> >>> I just sent V1, renaming hv_isolation_hw_cvm() to hv_isolation_type_hw(). >>> If your patch goes after mine, you just need to add to your 0004*: >>> >>> diff --git a/arch/arm64/hyperv/mshyperv.c b/arch/arm64/hyperv/mshyperv.c >>> index 4fdc26ade1d7..67a16b4d2235 100644 >>> --- a/arch/arm64/hyperv/mshyperv.c >>> +++ b/arch/arm64/hyperv/mshyperv.c >>> @@ -134,3 +134,8 @@ bool hv_is_hyperv_initialized(void) >>>          return hyperv_initialized; >>>   } >>>   EXPORT_SYMBOL_GPL(hv_is_hyperv_initialized); >>> + >>> +bool hv_isolation_type_hw(void) >>> +{ >>> +       return is_realm_world(); >>> +} >>> >>> >>> OR, you could pick mine 0001-* and make it part of your series, and I >>> can drop it from mine and make it dependent on yours. But mine is small >>> enough that it has higher chances of going in first..... >>> >> >> This patch set has already been applied to hyperv-next, so maybe you can >> rebase off that. >> > > Ok, I'll rebase my patches from hyperv-fixes to hyperv-next, and > resubmit. > > Thanks, > -Mukesh > On second thought, given these are overloaded functions, adding a new function makes it complicated. Since it's only two places, it's just not worth it. Punting on it for now... Thanks, -Mukesh