From: Daniel Cashman <dan.a.cashman@gmail.com>
To: Alan Cox <alan@linux.intel.com>,
mchehab@kernel.org, gregkh@linuxfoundation.org
Cc: rvarsha016@gmail.com, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs.
Date: Sat, 1 Apr 2017 19:50:05 -0700 [thread overview]
Message-ID: <f1c20331-9f25-b830-4b51-e7fc0ff7856a@gmail.com> (raw)
In-Reply-To: <1490808631.3367.5.camel@linux.intel.com>
My apologies; I did not review the TODO. Consider this withdrawn.
Dan
On 03/29/2017 10:30 AM, Alan Cox wrote:
> On Wed, 2017-03-29 at 09:57 -0700, Daniel Cashman wrote:
>> From: Dan Cashman <dan.a.cashman@gmail.com>
>>
>> Signed-off-by: Dan Cashman <dan.a.cashman@gmail.com>
>
>
> As the TODO asks - please no whitespace cleanups yet. They make it
> harder to keep other cleanups that fix (or mostly remove) code
> applying.
>
> Nothing wrong with the patch otherwise - but it should also have
> something in the commit message.
>
> Alan
>
prev parent reply other threads:[~2017-04-02 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 3:31 [PATCH] Remove atomisp/i2c style errors Daniel Cashman
2017-03-29 7:08 ` Greg KH
2017-03-29 16:57 ` [PATCH v2] staging: media: atomisp: Fix style. remove space before ',' and convert to tabs Daniel Cashman
2017-03-29 17:30 ` Alan Cox
2017-04-02 2:50 ` Daniel Cashman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1c20331-9f25-b830-4b51-e7fc0ff7856a@gmail.com \
--to=dan.a.cashman@gmail.com \
--cc=alan@linux.intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rvarsha016@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox