From: Jens Axboe <axboe@kernel.dk>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: bart.vanassche@wdc.com, tj@kernel.org, ming.lei@redhat.com,
Martin@Lichtvoll.de, stable@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] blk-mq: start request gstate with gen 1
Date: Mon, 16 Apr 2018 21:56:20 -0600 [thread overview]
Message-ID: <f1e278d0-bcf8-506d-7298-0a194f4893f0@kernel.dk> (raw)
In-Reply-To: <1523936780-1589-1-git-send-email-jianchao.w.wang@oracle.com>
On 4/16/18 9:46 PM, Jianchao Wang wrote:
> rq->gstate and rq->aborted_gstate both are zero before rqs are
> allocated. If we have a small timeout, when the timer fires,
> there could be rqs that are never allocated, and also there could
> be rq that has been allocated but not initialized and started. At
> the moment, the rq->gstate and rq->aborted_gstate both are 0, thus
> the blk_mq_terminate_expired will identify the rq is timed out and
> invoke .timeout early.
>
> For scsi, this will cause scsi_times_out to be invoked before the
> scsi_cmnd is not initialized, scsi_cmnd->device is still NULL at
> the moment, then we will get crash.
Oops, this looks good to me. Applied.
--
Jens Axboe
next prev parent reply other threads:[~2018-04-17 3:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 3:46 [PATCH] blk-mq: start request gstate with gen 1 Jianchao Wang
2018-04-17 3:56 ` Jens Axboe [this message]
2018-04-17 4:46 ` Ming Lei
2018-04-17 12:10 ` Martin Steigerwald
2018-04-17 14:34 ` jianchao.wang
2018-04-23 7:07 ` Martin Steigerwald
2018-04-23 8:39 ` Martin Steigerwald
-- strict thread matches above, loose matches on Subject: below --
2018-04-17 3:44 Jianchao Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1e278d0-bcf8-506d-7298-0a194f4893f0@kernel.dk \
--to=axboe@kernel.dk \
--cc=Martin@Lichtvoll.de \
--cc=bart.vanassche@wdc.com \
--cc=jianchao.w.wang@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=stable@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox