From: Joe Perches <joe@perches.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
apw@canonical.com, Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] checkpatch: check for missing \n at the end of logging message
Date: Thu, 09 Apr 2020 10:50:47 -0700 [thread overview]
Message-ID: <f212b3ad6c09e595cb91c2f7e8728d71e27f6833.camel@perches.com> (raw)
In-Reply-To: <05379b22-6755-368b-8127-8827fa020189@wanadoo.fr>
On Thu, 2020-04-09 at 19:34 +0200, Christophe JAILLET wrote:
> Le 09/04/2020 à 17:29, Joe Perches a écrit :
[]
> > lib/percpu-refcount.c:#define pr_fmt(fmt) "%s: " fmt "\n", __func__
> In this file, there are some WARN_ON.
> Are these log functions also influenced by pr_fmt?
No.
> > drivers/md/bcache/bcache.h:#define pr_fmt(fmt) "bcache: %s() " fmt "\n", __func__
> > drivers/md/bcache/bset.c:#define pr_fmt(fmt) "bcache: %s() " fmt "\n", __func__
> > tools/usb/usbip/libsrc/usbip_common.h:#define pr_fmt(fmt) "%s: %s: " fmt "\n", PROGNAME
>
> Tricky because all files that include it have to be checked.
> I won't touch these ones.
What a pity I do not know the French equivalent
for the children's taunt of "chicken!"...
cheers, Joe
next prev parent reply other threads:[~2020-04-09 17:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-07 20:49 [PATCH] checkpatch: check for missing \n at the end of logging message Christophe JAILLET
2020-04-08 0:33 ` Joe Perches
2020-04-08 20:19 ` Marion & Christophe JAILLET
2020-04-08 2:14 ` Joe Perches
2020-04-08 20:23 ` Marion & Christophe JAILLET
2020-04-09 3:10 ` Joe Perches
2020-04-09 7:24 ` Christophe JAILLET
2020-04-09 7:24 ` Christophe JAILLET
2020-04-09 15:29 ` Joe Perches
2020-04-09 17:34 ` Christophe JAILLET
2020-04-09 17:34 ` Christophe JAILLET
2020-04-09 17:50 ` Joe Perches [this message]
2020-04-09 18:52 ` Christophe JAILLET
2020-04-09 18:52 ` Christophe JAILLET
2020-04-09 21:40 ` Joe Perches
2020-04-09 10:40 ` Dan Carpenter
2020-04-10 17:35 ` Christophe JAILLET
2020-04-10 19:46 ` Joe Perches
2020-04-10 19:53 ` Joe Perches
2020-04-11 6:48 ` Christophe JAILLET
2020-04-11 6:48 ` Christophe JAILLET
2020-04-11 10:10 ` Andy? checkpatch $stat question (was: Re: [PATCH] checkpatch: check for missing \n at the end of logging message) Joe Perches
2020-04-11 7:12 ` [PATCH] checkpatch: check for missing \n at the end of logging message Christophe JAILLET
2020-04-11 7:12 ` Christophe JAILLET
2020-04-11 7:13 ` Marion & Christophe JAILLET
2020-04-11 10:17 ` Joe Perches
2020-04-11 10:27 ` Christophe JAILLET
2020-04-11 10:27 ` Christophe JAILLET
2020-04-10 19:34 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f212b3ad6c09e595cb91c2f7e8728d71e27f6833.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox