From: "Nuno Sá" <noname.nuno@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
"Nuno Sá" <nuno.sa@analog.com>,
"Lars-Peter Clausen" <lars@metafoo.de>
Subject: Re: [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages
Date: Wed, 02 Mar 2022 20:56:40 +0100 [thread overview]
Message-ID: <f22f0f902079e10bbc065733de7c41f7dc164f98.camel@gmail.com> (raw)
In-Reply-To: <Yh+SQgD0Bq5qq6Cm@smile.fi.intel.com>
On Wed, 2022-03-02 at 17:50 +0200, Andy Shevchenko wrote:
> On Sun, Feb 13, 2022 at 05:55:59PM +0000, Jonathan Cameron wrote:
> > On Thu, 10 Feb 2022 15:55:20 +0200
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> > > In a couple of messages the constants, which have their
> > > definitions,
> > > are hard coded into the message text. Unhardcode them.
> > >
> > > While at it, add a trailing \n where it's currently missing.
> > >
> > > Signed-off-by: Andy Shevchenko
> > > <andriy.shevchenko@linux.intel.com>
> > > Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> >
> > Mostly so I can remember what is going on with this patch,
> > Nuno is OoO and planning to test this series when he returns.
> >
> > Given that I'll wait on Nuno's testing.
>
> Any news?
>
Started to prepare things by the end of the day. Should be tested by
tomorrow.
- Nuno Sá
prev parent reply other threads:[~2022-03-02 19:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 13:55 [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Andy Shevchenko
2022-02-10 13:55 ` [PATCH v3 2/3] iio: temperature: ltc2983: Use single error path to put OF node Andy Shevchenko
2022-02-10 13:55 ` [PATCH v3 3/3] iio: temperature: ltc2983: Make use of device properties Andy Shevchenko
2022-03-03 13:31 ` Sa, Nuno
2022-03-03 13:57 ` Andy Shevchenko
2022-03-03 14:53 ` Sa, Nuno
2022-03-03 14:23 ` Andy Shevchenko
2022-03-03 14:27 ` Andy Shevchenko
2022-03-03 14:52 ` Sa, Nuno
2022-02-13 17:55 ` [PATCH v3 1/3] iio: temperature: ltc2983: Don't hard code defined constants in messages Jonathan Cameron
2022-02-14 9:23 ` Andy Shevchenko
2022-03-02 15:50 ` Andy Shevchenko
2022-03-02 19:56 ` Nuno Sá [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f22f0f902079e10bbc065733de7c41f7dc164f98.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox