From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225lXe7pE+r5tY5xcsiIOibT4+SuVA2BxTa6U1R9YDqCYJY1gExUjD9DOXiPvEQO/sVLHZ5o ARC-Seal: i=1; a=rsa-sha256; t=1516921633; cv=none; d=google.com; s=arc-20160816; b=OFHoYGFjgvvJRFB5a0b/5sxhqxRWeyEXkmBryugbPmY+KF3I/LWpfDM1n1WcLauVeB momioxSg+bHmQjmNmfTYpRjYnYfWv1k1tNvXwU1RLFFtXyD2Ys05ksppJuW0uCv5+w3z cEbjoNbRFJcmjdzUcdDEJ3ityhdXzJdQFPQBL+UDV3WFQw8iqMs5vtAviGCWHyJ30K7h Mzb5AQ76bZYjb0qoToh05xDD+sWVGtJvxylm+0oEhuckIl/y8q9JThlyChO7s3dAfR9m qndjdRTbV1J01o0SudADul8rPCghp78PpkZ5qz8nsnxxys9hSTkUonWW2djz1hcDrKKz Wa5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=rSf3Fi4ZH13HAvQN5p+A+u3xzWPlMIHSvdLpVn2p88I=; b=tWVRJPUfZKva9a+gZYYHNofLUKoFufDgIeYqgnwLEqPQsc55+saO6Ftq8z9iVVnE1h u/ZnsH7BaMvkbs482C8J2d6b8r43YnnwWSjj0SCMlpQQsFg0gfliVPAI98/CXsDfIhdm kikPO7pmFvBIYct1edKE9BfhP/rXyQabybyUTTJm0wBDDSmJhG58Z1h2Yobk5B1owUgV QN0/lCji9tLpbsX7sX8p6Hvom+2acHEUKzj8ezddlo55CIZLl0E5Usk7s6eAYBCywm86 LyHEw03Q7UMW1qEfQFsNll8naaunhD5uXZgPCQ0qGkMl/Lxh8h+GKO1M2+QDyDCoKLde akHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of tim.c.chen@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=tim.c.chen@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of tim.c.chen@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=tim.c.chen@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,413,1511856000"; d="scan'208";a="13537931" Subject: Re: [RFC PATCH 1/2] x86/ibpb: Skip IBPB when we switch back to same user process To: Andy Lutomirski , Andi Kleen Cc: Peter Zijlstra , Arjan van de Ven , LKML , KarimAllah Ahmed , Andrea Arcangeli , Ashok Raj , Asit Mallick , Borislav Petkov , Dan Williams , Dave Hansen , David Woodhouse , Greg Kroah-Hartman , "H . Peter Anvin" , Ingo Molnar , Janakarajan Natarajan , Joerg Roedel , Jun Nakajima References: <20180125085820.GV2228@hirez.programming.kicks-ass.net> <20180125092233.GE2295@hirez.programming.kicks-ass.net> <86541aca-8de7-163d-b620-083dddf29184@linux.intel.com> <20180125135055.GK2249@hirez.programming.kicks-ass.net> <20180125164139.GM2269@hirez.programming.kicks-ass.net> <20180125181852.GL2249@hirez.programming.kicks-ass.net> <20180125204625.GN2269@hirez.programming.kicks-ass.net> <87h8r9k3du.fsf@linux.intel.com> From: Tim Chen Message-ID: Date: Thu, 25 Jan 2018 15:07:11 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1590523944221221739?= X-GMAIL-MSGID: =?utf-8?q?1590607618981456073?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 01/25/2018 02:01 PM, Andy Lutomirski wrote: > On Thu, Jan 25, 2018 at 1:57 PM, Andi Kleen wrote: >> Andy Lutomirski writes: >>> >>> That being said, just stashing last_user_mm without any refcounting >>> should be fine. >> >> If last_user_mm is freed and reallocated by a different process, >> then that would miss the IPBP incorrectly. >> > > Hmm, right. So ctx_id it is. > > --Andy > Thanks. Using ctx_id is a pretty clean approach. I will refresh this patch and drop the second patch. Tim