From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 130852DA774 for ; Mon, 5 Jan 2026 07:59:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767599959; cv=none; b=VjqSkCA3XgW6uQ72yKQ9Y3K+bAo6Tbv8z2+hTie/xIg9mRUPE+epHLhOB8VI5yOdPI+powgLvXKrQau2O9TYhXEHYs0IG6FBLq18Hh3YKshwhHhSoTqwo1wuTzfZKp4IhZhaVIHvvDJQqMFE7Ypzog7KcEa7xRO+3q2PbDkawEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767599959; c=relaxed/simple; bh=7PvMSK/ESGiEefK8GPVWl+z2vMPgQpl8RyoXIpvv1do=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Fwn4lmS1MrGC3c6XlrR71xYV1VyAo2qaIggEJckuRpgJnDc4Ooij3QfVz6iuR70pWMIev411XwSckLpmbT7bA58js90MpUcRMdcqxrxHgNZAhUgNsIggZTxw6xz0hxHry8m2gnkMlehss3QADqN1OVMRmihRzY/5ETjnll430gA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Kl3kxuBJ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Kl3kxuBJ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11463C116D0; Mon, 5 Jan 2026 07:59:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1767599958; bh=7PvMSK/ESGiEefK8GPVWl+z2vMPgQpl8RyoXIpvv1do=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Kl3kxuBJT2+Wke7Xg4K9NNPbWIIG0gNnERY6cI7Qb6hfSjgtYzlnYGiS8YQsQ5jJ6 +TXpqAybsYsICt3/SXvGEuonJvnLexF9QKXTOYOQSAUbHN57C8slgRvMuho8fzfOO3 nT47yinhQqBX/p44JdJQvtgaUb1EsawVQGJ7OXcQJdUgi6SuNl23bWsdovBM2hetro C+pW97CS634FE659NcojWFSlmJBwYtwjIdiwzBEhdAKbBp5NRkkEpTHXzx6WB/Ezkg zuI6Ywy49LDibEymqr442IIfcxn982Ma9HP3TRAkvATPt1lawUE4jGct5pQE1sC8xs qLsbTBdnGYHdA== Message-ID: Date: Mon, 5 Jan 2026 07:59:13 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] nvmem: nintendo-otp: Fix potential NULL pointer dereference in nintendo_otp_probe() To: Haotian Zhang , srini@kernel.org Cc: linkmauve@linkmauve.fr, linux-kernel@vger.kernel.org References: <20251210033803.1720-1-vulab@iscas.ac.cn> Content-Language: en-US From: Srinivas Kandagatla In-Reply-To: <20251210033803.1720-1-vulab@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/10/25 3:38 AM, Haotian Zhang wrote: > of_match_device() may return NULL if no match is found. > Dereferencing the return value of_id in nintendo_otp_probe() This does not make sense, nintendo_otp_probe() will never be called without a dt compatible match. Why do you think this will be null? --srini > without a check could lead to a NULL pointer dereference. > > Add a check for of_id and return -ENODEV upon failure. > > Fixes: 3683b761fe3a ("nvmem: nintendo-otp: Add new driver for the Wii and Wii U OTP") > Signed-off-by: Haotian Zhang > --- > drivers/nvmem/nintendo-otp.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/nvmem/nintendo-otp.c b/drivers/nvmem/nintendo-otp.c > index 355e7f1fc6d5..89b15a58bf88 100644 > --- a/drivers/nvmem/nintendo-otp.c > +++ b/drivers/nvmem/nintendo-otp.c > @@ -87,6 +87,9 @@ static int nintendo_otp_probe(struct platform_device *pdev) > .root_only = true, > }; > > + if (!of_id) > + return -ENODEV; > + > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > if (!priv) > return -ENOMEM;