From: Jens Axboe <axboe@kernel.dk>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
Subject: Re: [PATCH] blkdev: make struct block_device_operations.devnode() take a const *
Date: Wed, 9 Nov 2022 12:41:09 -0700 [thread overview]
Message-ID: <f249f608-d9cf-7ba9-5050-dfc97e543d55@kernel.dk> (raw)
In-Reply-To: <20221109144843.679668-1-gregkh@linuxfoundation.org>
On 11/9/22 7:48 AM, Greg Kroah-Hartman wrote:
> The devnode() callback in struct block_device_operations should not be
> modifying the device that is passed into it, so mark it as a const * and
> propagate the function signature changes out into the one subsystem that
> actually uses this callback.
>
> Cc: linux-block@vger.kernel.org
> Cc: Jens Axboe <axboe@kernel.dk>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>
> Jens, I have some dependent kobject/driver core changes that require
> this change in the works. Can I take this through the driver core tree
> for 6.2-rc1?
Yeah go ahead, you can add my:
Acked-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
next prev parent reply other threads:[~2022-11-09 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 14:48 [PATCH] blkdev: make struct block_device_operations.devnode() take a const * Greg Kroah-Hartman
2022-11-09 19:41 ` Jens Axboe [this message]
2022-11-10 17:23 ` Greg Kroah-Hartman
2022-11-15 9:13 ` Christoph Hellwig
2022-11-15 10:30 ` Greg Kroah-Hartman
2022-12-02 18:28 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f249f608-d9cf-7ba9-5050-dfc97e543d55@kernel.dk \
--to=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox