From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83AF9C433EF for ; Tue, 26 Apr 2022 17:34:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349508AbiDZRhi (ORCPT ); Tue, 26 Apr 2022 13:37:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349185AbiDZRh2 (ORCPT ); Tue, 26 Apr 2022 13:37:28 -0400 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C99092D3A for ; Tue, 26 Apr 2022 10:34:20 -0700 (PDT) Received: by mail-io1-xd2c.google.com with SMTP id m13so7467033iob.4 for ; Tue, 26 Apr 2022 10:34:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7f2dI15a4+fxCm2oUbnayxZipYVTc4CPiFnYf4iZd2U=; b=SREAqgM7dV17pgSKvTHXqGRtHaa149tdP3zeKDxtvrWfF/g9kSkykZn7f2kF/kZLrp 4ADMNFdr49SVVqqxE4FHv2OBrlkZEsjAwubpihKozfaxZGLx7hfE7uTEAW3lvU4/70if Lzcv5LPTbN395oaYwmC48671h2iLMAq3lDqPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7f2dI15a4+fxCm2oUbnayxZipYVTc4CPiFnYf4iZd2U=; b=KkKXM4pIaH8fPrR30wRjqDtOawkGts1NL6wHeAIgFvgH1zPgzmK9hiWbV5RyJeiwiz AHOdk1lToQ8Fw1Pyx+CU/oQVC54i7ki/G0mFzv+vkIUceNEYUrFyA9/8n2u6bf4NaBJj 3qKVfq2kEvHRfwqguYHwy2AmMIY8ssL/e1c+R6JoSj4k0oB5spbTqNEz0AxiVIrf4k0s AkAub27thP3lFvFbER2OZeII+CQ/xM3wq1zcWgoFQlS/6F4Wf4t96/eUJ1uzBv7gNYiy 39UEphMd+hlAErVlwWJ8FZL/TcYOCVgJ8X4GRO3W54I50hjTyNxo0LpvGHsmY8nYc0d2 RIEg== X-Gm-Message-State: AOAM530YggWk2z262CgD7JfhCYxLmtEeBE7cLC+HJTDfZMnykNRbsP+P ovUpe9nH9FTKAYKhnhzbCnsH/g== X-Google-Smtp-Source: ABdhPJzQGDlIXE5ent6k2MVRos1IeGAWobjiKgxDUQSt7g0QXIN9BmEROJsT2JY8WurBH/mD6/+5sA== X-Received: by 2002:a6b:490f:0:b0:657:5e68:66b8 with SMTP id u15-20020a6b490f000000b006575e6866b8mr7896021iob.102.1650994459551; Tue, 26 Apr 2022 10:34:19 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id t11-20020a922c0b000000b002c85834eb06sm8164495ile.47.2022.04.26.10.34.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 10:34:19 -0700 (PDT) Subject: Re: [PATCH v2 6/6] selftests: vm: add /dev/userfaultfd test cases to run_vmtests.sh To: Axel Rasmussen , Alexander Viro , Andrew Morton , Charan Teja Reddy , Dave Hansen , "Dmitry V . Levin" , Gleb Fotengauer-Malinovskiy , Hugh Dickins , Jan Kara , Jonathan Corbet , Mel Gorman , Mike Kravetz , Mike Rapoport , Nadav Amit , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , zhangyi Cc: linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Shuah Khan References: <20220422212945.2227722-1-axelrasmussen@google.com> <20220422212945.2227722-7-axelrasmussen@google.com> From: Shuah Khan Message-ID: Date: Tue, 26 Apr 2022 11:34:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220422212945.2227722-7-axelrasmussen@google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/22/22 3:29 PM, Axel Rasmussen wrote: > This new mode was recently added to the userfaultfd selftest. We want to > exercise both userfaultfd(2) as well as /dev/userfaultfd, so add both > test cases to the script. > > Signed-off-by: Axel Rasmussen > --- > tools/testing/selftests/vm/run_vmtests.sh | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index 5065dbd89bdb..57f01505c719 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -121,12 +121,17 @@ run_test ./gup_test -a > run_test ./gup_test -ct -F 0x1 0 19 0x1000 > > run_test ./userfaultfd anon 20 16 > +run_test ./userfaultfd anon:dev 20 16 > # Hugetlb tests require source and destination huge pages. Pass in half the > # size ($half_ufd_size_MB), which is used for *each*. > run_test ./userfaultfd hugetlb "$half_ufd_size_MB" 32 > +run_test ./userfaultfd hugetlb:dev "$half_ufd_size_MB" 32 > run_test ./userfaultfd hugetlb_shared "$half_ufd_size_MB" 32 "$mnt"/uffd-test > rm -f "$mnt"/uffd-test > +run_test ./userfaultfd hugetlb_shared:dev "$half_ufd_size_MB" 32 "$mnt"/uffd-test > +rm -f "$mnt"/uffd-test > run_test ./userfaultfd shmem 20 16 > +run_test ./userfaultfd shmem:dev 20 16 > > #cleanup > umount "$mnt" > Looks good to me. Reviewed-by: Shuah Khan thanks, -- Shuah