Re: [PATCH 1/3] dt-bindings: gpio: spacemit: add support for K1 SoC

Yixun Lan
2024-09-04T08:39:26Z

On 09:42 Wed 04 Sep , Krzysztof Kozlowski wrote:
> On 04/09/2024 09:05, Yixun Lan wrote:
> > Hi Krzysztof
>
> >>> + "#interrupt-cells":
> >>> + const: 2
> >>> + description: |
> >>> + The first cell is the GPIO number, the second should specify
> >>> + flags. The following subset of flags is supported:
> >>> + - bits[3:0] trigger type flags (no level trigger type support)
> >>> + 1 = low-to-high edge triggered
> >>> + 2 = high-to-low edge triggered
> >>> + Valid combinations are 1, 2, 3
> >>
> >> Hm? No, you must use standard interrupt flags, not custom ones.
> >>
> > It should be same as standard flags, my intention here was try to say
> > the controller support edge trigger only, but no level trigger flags (4, 8)
> > should I just replace number to macro, and put it like this:
>
> Then just say that level interrupts are not supported. Do not refer to
Ok, got

> some bits (bits of what?).
>
the flags IRQ_TYPE_LEVEL_HIGH=4, IRQ_TYPE_LEVEL_LOW=4

--
Yixun Lan (dlan)
Gentoo Linux Developer
GPG Key ID AABEFD55