From: Shuah Khan <skhan@linuxfoundation.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Punit Agrawal <punit.agrawal@bytedance.com>
Cc: shuah@kernel.org, adobriyan@gmail.com,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kselftest@vger.kernel.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] selftests: proc: Fix proc-empty-vm build error on non x86_64
Date: Wed, 9 Nov 2022 18:44:54 -0700 [thread overview]
Message-ID: <f27ebae6-cea7-36dc-b7a6-b0d62b3c3b0d@linuxfoundation.org> (raw)
In-Reply-To: <20221109160243.0db030ca1cbae5f180af3855@linux-foundation.org>
On 11/9/22 17:02, Andrew Morton wrote:
> On Wed, 9 Nov 2022 22:11:03 +0000 Punit Agrawal <punit.agrawal@bytedance.com> wrote:
>
>> The proc-empty-vm test is implemented for x86_64 and fails to build
>> for other architectures. Rather then emitting a compiler error it
>> would be preferable to only build the test on supported architectures.
>
> Why does it fail? What would be involved in making it available
> on other architectures?
>
I have the same question and also don't like adding TEST_GEN_PROGS_x86_64
Please see my comments on the two patches regarding this.
thanks,
-- Shuah
next prev parent reply other threads:[~2022-11-10 1:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-09 22:11 [PATCH v2 1/2] selftests: proc: Fix proc-empty-vm build error on non x86_64 Punit Agrawal
2022-11-09 22:11 ` [PATCH v2 2/2] selftests: proc: Mark proc-pid-vm as x86_64 only Punit Agrawal
2022-11-10 1:12 ` Shuah Khan
2022-11-10 0:02 ` [PATCH v2 1/2] selftests: proc: Fix proc-empty-vm build error on non x86_64 Andrew Morton
2022-11-10 1:44 ` Shuah Khan [this message]
2022-11-10 14:34 ` [External] " Punit Agrawal
2022-11-10 0:20 ` Shuah Khan
2022-11-10 14:45 ` [External] " Punit Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f27ebae6-cea7-36dc-b7a6-b0d62b3c3b0d@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=punit.agrawal@bytedance.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox