From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from rtits2.realtek.com.tw (rtits2.realtek.com [211.75.126.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA2863B1; Mon, 26 Feb 2024 01:18:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=211.75.126.72 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708910315; cv=none; b=dmvWBApX1Qw+Dxde1tcXD5sZzy22OHeK6vuSa5h3lBP2kprAJczbItRZsgpEn+NhAPCm02pZn4Eflgyr9WtetwM8h+UxBdg8NcjCA7Zq8KW3HcMnqrqGA+7cLg6pKeqz3Ix829fTbz0Gkzc5Y+IvnjfJOJ6DG71zOO/7dowsCb8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708910315; c=relaxed/simple; bh=zgFi5HFXIGLekCnyN5/QrVsmTT6G3lncBn0Sub7vMT0=; h=From:To:CC:Subject:Date:Message-ID:References:In-Reply-To: Content-Type:MIME-Version; b=IM/nmUNpioyLGRHU5Sd/zn9loGHqCumX+XuefzURWVcqG3OJ99H80UiyKLRe4F5doxfcKx9nT+jyzqfUnOfImerzSLDDbJjw62u+Pq++Uj/rE78409wVj/0B0aueQQU2Nw2jYC2hEuAuuOywfo1wgEcnFHcISAdnlnMXW7xRauU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com; spf=pass smtp.mailfrom=realtek.com; arc=none smtp.client-ip=211.75.126.72 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=realtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=realtek.com X-SpamFilter-By: ArmorX SpamTrap 5.78 with qID 41Q1I5NQ03370148, This message is accepted by code: ctloc85258 Received: from mail.realtek.com (rtexh36506.realtek.com.tw[172.21.6.27]) by rtits2.realtek.com.tw (8.15.2/2.95/5.92) with ESMTPS id 41Q1I5NQ03370148 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Feb 2024 09:18:06 +0800 Received: from RTEXMBS01.realtek.com.tw (172.21.6.94) by RTEXH36506.realtek.com.tw (172.21.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.17; Mon, 26 Feb 2024 09:18:06 +0800 Received: from RTEXMBS04.realtek.com.tw (172.21.6.97) by RTEXMBS01.realtek.com.tw (172.21.6.94) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 26 Feb 2024 09:18:05 +0800 Received: from RTEXMBS04.realtek.com.tw ([fe80::c9b7:82a9:7e98:fa7f]) by RTEXMBS04.realtek.com.tw ([fe80::c9b7:82a9:7e98:fa7f%7]) with mapi id 15.01.2507.035; Mon, 26 Feb 2024 09:18:05 +0800 From: Ping-Ke Shih To: Shiji Yang , "linux-wireless@vger.kernel.org" CC: Jes Sorensen , Kalle Valo , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs() Thread-Topic: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_aifs() Thread-Index: AQHaZl1h2HbwH7TQQEG2gknoSwbFfrEb1M2g Date: Mon, 26 Feb 2024 01:18:05 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW x-kse-serverinfo: RTEXMBS01.realtek.com.tw, 9 x-kse-antispam-interceptor-info: fallback x-kse-antivirus-interceptor-info: fallback Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-KSE-AntiSpam-Interceptor-Info: fallback > -----Original Message----- > From: Shiji Yang > Sent: Friday, February 23, 2024 9:35 PM > To: linux-wireless@vger.kernel.org > Cc: Jes Sorensen ; Kalle Valo ;= linux-kernel@vger.kernel.org; > Shiji Yang > Subject: [PATCH] wifi: rtl8xxxu: fix mixed declarations in rtl8xxxu_set_a= ifs() >=20 > Moving struct ieee80211_sta *sta variable definition to the front > of the code to fix the ISO C90 forbids mixed declarations and code > warning. I suppose there will be no this kind of warnings after the commit b5ec6fd286df ("kbuild: Drop -Wdeclaration-after-statement") sinc= e v6.5. But as commit message mentioned --=20 " It will still be recommeneded to place declarations at the start of a scope where possible, but it will no longer be enforced." Then, this patch looks good to me.=20 >=20 > Fixes: 43532c050f8e ("wifi: rtl8xxxu: support multiple interfaces in set_= aifs()") > Signed-off-by: Shiji Yang Reviewed-by: Ping-Ke Shih