From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E131392C48 for ; Tue, 14 Jul 2026 06:20:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784010036; cv=none; b=KyZJTBy3pwcmwP7w4QUHOdwVGfAvkZKcpjlyqw8wwSUvmxgOy96qQDLKyR1ozlRHvCUHe6uTCP1aiiRYQ68lT8g76hFt3OVu+GfN/Lj+dKvBbcTJXgf87nV8JkFkRGymWltKPslQn8AdsSqXZxjbB/dEBogPo5IoJir9d4dBjyo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784010036; c=relaxed/simple; bh=QyXyUIEjbJhtNHfUEsgKzNkLwk4T451USFyfPbPc34U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cL5GVf0W10YFQG5hinh+dIONXJCqLFMvZhRhpnwCqnNuHuopPyw4GAmAlIM39o9KnWE9BksocCO8CNzZ+IsO8TbdtAt3pShEBTQiuhdRkLwtKfFmA7ey4/Nw6Vz3MMyRInTcr+OoXNgueXLUYNO/JghTG7GfTASVfdfKY80Hzmw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=JpdbWPrp; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="JpdbWPrp" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-493f4638f4aso5164875e9.3 for ; Mon, 13 Jul 2026 23:20:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1784010033; x=1784614833; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=aWonftaRHsp2QJOOP2/Zw1LuKiveR0smAimlqpU3fYE=; b=JpdbWPrpl1Cf5ra0ia0raaKyH4tSDbEzkcMPnsDyqzcesFu2nIx74wz/VAl5g6ohMI 1CE6uQQ2q6ujKWhfHWaA1wkgaOHvlK8v6iq+bs0BEXlGWcz8gsf67sN2Mhs+3LGR9qdt 1BaY7zshBIhR8JXPxcHA91myvsd3FdX4BgpwbYI23YnFzld/kewtUUxAQWKEc9VIKadX lRCpRYRcb5tlDl3iYLcefp1RVfv2MDsQ62a7jwzgxQK5z6WUFBucG6eR7xWVoMetBS1V uvWwCRgPEy14VL40paLYf77OOWfspqeicEMlGWwXZdGZDfzB04rrrcF38PV6h4FU7gN5 dZBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784010033; x=1784614833; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aWonftaRHsp2QJOOP2/Zw1LuKiveR0smAimlqpU3fYE=; b=NXmZ58UD/OoGGNYMKqMtt9Ie0yFgWlaMTTnrvQYgp+bTfi4W9lWdxQqWnROoDNSAee aKQbpRM2zTAOvOcm0xP25uNmTrlcAJ9qVXFJRU/RCPWdhtLhqVF9FkxODl1ZgFbiH84L ANyEV4belNIUHLnyRyujHsaTneM8aCvAqIvsbz/BXkJBtmJvozTbUlT2hUKK4NJE0inF GqW1meuybe2K4Um0P6nJJg0mL0H72phsi5VsUFmD/qewZa87M+/hEiWHZ4pCQq+A+sjG DLGiaWpZx+STnUCfJMXGMRRlcO79vfjhtP8ZE+jDpkDlN7UmUtW5oeayq+38K9W0q/kD J18w== X-Forwarded-Encrypted: i=1; AHgh+Ro5XbHI1kkQ+chmhGPTpXsb59dHzwmRQe5SMlNJY21lCSazSqdTpFUR1ctKpFSncQKMZQoNjd1yD+xr5Yc=@vger.kernel.org X-Gm-Message-State: AOJu0YwdccWuRKv9i1Bgd1O9Xw5mt5euMmzVTqWp9ir/7SpUqOoGhZWU Ct76Wh6WfHugcQC5iwCL08D/Wwie1CLAayhSFX0MhjZE87wBbO3ni22uuyapGb22nBE= X-Gm-Gg: AfdE7ck5WVY1rWx1LUCcyQPRN81H1S16pvYpKs4rDqTPytFDVaHKEEuT43QK/o2ziWJ YWoxcUKbFCzNFnWjHLnkI93uDvUG7ppScTKQ2CIqrVvfYPa69YbsppaMwtvQf6rO+rLPGansfx2 6IuHvpXQxUBveyLyWMs7EtKPMoChbi3SJvnKH2rQ8ZyGOeSBgKE52iR2bizP3X9cMxCJdktrWAD KMZ/na/eL3zLY8q0bkUYmXG3EO993XOXCM/nSvU/85D1WAL26f7IMWzwayOJrB5QSJYUdzcX1t7 JxczWpbkqMcfApE8QTDUUAoyQ5YLwtOIV/WZrk1/3ZtgOL2QBtveoHsRlLgr6sxBoXbXBxB3Hbw 7mOZjre8kVPnaiiTDnIwoPeZtnjZyOBd4ySVzqp+HysuJxIh1/OcM7K7kDcFQnK3SdKfuGcBkd7 jz3SLiwe52YShJZiXjA8llLajJuwxOxKl6GWeN6sOUHxLS+uth/37G6bc= X-Received: by 2002:a05:600c:16ca:b0:493:c1bc:79bd with SMTP id 5b1f17b1804b1-493f88180f9mr76016865e9.20.1784010033439; Mon, 13 Jul 2026 23:20:33 -0700 (PDT) Received: from ?IPV6:2001:a61:13c3:1c01:3157:c849:4aaa:fa65? ([2001:a61:13c3:1c01:3157:c849:4aaa:fa65]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-495087366c0sm95826825e9.7.2026.07.13.23.20.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jul 2026 23:20:33 -0700 (PDT) Message-ID: Date: Tue, 14 Jul 2026 08:20:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] usb: core: strengthen size check in usb_parse_interface() To: Greg Kroah-Hartman , Alan Stern Cc: Griffin Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260713-usb_core_patches_1-v1-0-7721c2b33f53@kroah.com> <20260713-usb_core_patches_1-v1-2-7721c2b33f53@kroah.com> <2026071406-ambiance-rogue-39bb@gregkh> Content-Language: en-US From: Oliver Neukum In-Reply-To: <2026071406-ambiance-rogue-39bb@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 14.07.26 07:53, Greg Kroah-Hartman wrote: > On Mon, Jul 13, 2026 at 12:13:04PM -0400, Alan Stern wrote: >> No, because usb_parse_configuration() has already performed this check. >> A malicious device can't avoid that earlier check, and so we don't need >> to do it again. > > Ok, this is my fault. Speaking about fault here isn't likely to be productive. The error is easy to make. I made it once. We have the power of using comments. That place needs one. Regards Oliver