From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751047AbcEGSFa (ORCPT ); Sat, 7 May 2016 14:05:30 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:34326 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbcEGSF2 (ORCPT ); Sat, 7 May 2016 14:05:28 -0400 Subject: Re: [PATCH] Staging: android: gio: fixes a variable type issue and tabbing issues To: Greg KH References: <1462636597-15311-1-git-send-email-thibmorozier@gmail.com> <20160507171517.GA20652@kroah.com> Cc: arve@android.com, riandrews@android.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Thimo Braker Message-ID: Date: Sat, 7 May 2016 20:05:22 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1 MIME-Version: 1.0 In-Reply-To: <20160507171517.GA20652@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the reply. Will give that a check. :) Got pointed to torvalds/linux-2.6 by some other guy. Will have a look in the other repo. Also, would you rather have me send a patch for every type (eg tabbing fix, capital fix, spelling fix, 80-char fix, etc)? (Just to be sure I properly understood you.) Thanks, Thimo B. On 7-5-2016 19:15, Greg KH wrote: > On Sat, May 07, 2016 at 10:56:37AM -0500, Thimo Braker wrote: >> Fixes issues with the coding style checks. > What issues? Always be specific, and describe what you are doing. Also > don't put more than one "thing" in a single patch (hint, "coding style > cleanups" are not one thing.) > >> Signed-off-by: Thimo Braker >> --- >> drivers/staging/android/timed_gpio.c | 36 +++++++++++++++++----------------- >> drivers/staging/android/timed_gpio.h | 8 ++++---- >> drivers/staging/android/timed_output.c | 16 +++++++-------- > These files are not in linux-next, please always work from that, they > have been gone from my tree for months now :( > > thanks, > > greg k-h