From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35FDD3ADB9B for ; Tue, 12 May 2026 15:57:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778601467; cv=none; b=bX0kK5hZmQ+fWT4Sih3lqy+hzFnGGwcf+AXDocgZhqoUHp/F/2fkbpU+eCEaxprGcOqborJ297TumRixE4Kvjw2UB+qLgyD49LhoIp7CKJq2Be6TY+jQ0wol0QHoGL4OQyoo8OIsi4dDhFMNb5auI5cBDWiTbjyMRFxGG76l2Lg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778601467; c=relaxed/simple; bh=ox2uSWFpauWjzzvNuCrFahLrj3lcl/0QEqcGEGnZIK0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p+ESzwhTy3BjrAPREoJRIy42Yz4R5GTKs71S3Q+UAgAiML45q3bQEyaD7Tstq+mSmKxKwyK2mheE4zfs5WIvoIw9LFKAZT1z8jfb3+CavglhuLVCHUapfvYQuzuJnMwFSi8cp5m50ZWBtDd906bww6ACrbvsNvN9Pv9hsaw2mgY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=hf21uwPD; arc=none smtp.client-ip=209.85.167.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="hf21uwPD" Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-479fc1fc048so4113090b6e.1 for ; Tue, 12 May 2026 08:57:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778601465; x=1779206265; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=UY5jtfu2qbBerQcmhH9e8mkt19otLXw2xZhPPXUcnUI=; b=hf21uwPD4WB+7Nc1VGD+4yxq+MU9LJjsZkFIvQKYr2kAemHe39efdABbqa/zdanOih p48kuh4U1U2z3p2n29KxrJ3GpvZyTYIG38x66OqGaNn7d8IAexy/Ndw0YhGkx8aaCVsg q6theRfGB/ebsBkgTQCDOxsAFjDHUHrp/fBEbgJVUKjvL8ew3L3/45sTLjyhJKD0M2fM IVDIHNjwGbecm+kULPK2+UbTOoSJEPJs+P0Rpk51kWEmh8xhsdPiwvfmisD5InsF4qmf aeOfhcUZtSc07XXJ9iAG9WHu20UEyOc4xmCl+sJ8MX6kLJ0pkbt2yB2BY9rXg+AIdiNr UrMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778601465; x=1779206265; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UY5jtfu2qbBerQcmhH9e8mkt19otLXw2xZhPPXUcnUI=; b=MFBtUSd1tC8bHNrkrlX7bf2dislXxLFWN0m0qm75HjoBJQqVbO4MydLxQXBLCX6l8O HoW4KHI4GHcIcvaSCHWntKDOA4ylHSoeMFh0VpS8V4Z4HiVtaF5UYZmiWdTcqCbyyY0V +upErDSE4FteboKzXzgu46GCU3xIs1HmXDnGxtP0swACIDfqTIRooqWMy8LUtGmEtr4Y ot9J39fZ5XIqpwwD2XNn5JcYSgXe6GBjwxQ3HWcHvOcHmav1Wlo8YKeZEqmWcAM2Y/Qt PavrJbbKZzMUqdbE+jbxboUGeHYd81qEq1IRSThGi/7JVMsmWu41iskGgl8MdyQ903gK 6aRQ== X-Forwarded-Encrypted: i=1; AFNElJ/5IlpoV1IFURXuITfkEk2mHkn4uT/jx2zad3ceNqjoZ9FOhzq4mySYfLXyjIVj+N5dnaWPTJlKwsgnrzU=@vger.kernel.org X-Gm-Message-State: AOJu0YwBeNmD7/wrmnNV2cWvjgCqAcpanfjw0fFQDfqTJi+rVEDpHx1G Niq/JRYh9besNCsbhMxhx0brMTB0a9riHZPSJwonQMHkZkeqXWz4kNFKMZdIY2ghF1I= X-Gm-Gg: Acq92OHTn0XSt+/AlbfKcaNDjBXUmY/n9gnDZzF4WScapek3KVLBRCUuoyL6aus74ub mcfwvAV5RpECXlZQiQAVEl0gA3FFf6ihitm5W39crsv0V2joDB0oDx5JNTyzm49oK/uYoSaWD82 WC5BWapwaikqMQhCKIzMxwSXZKywu6vwRRLlpKt02vLF/oTZDaFcgS4H4E4viMeOyyck5G0j0Kc iTyOi4AhM3Ba2ZJqiI2gLTxbig73CAn2GHFMJL7Kh7sKTAH2xf3gMLHz3XsmzQFdsEdKKoN/RGT V6TTLKtu9l79GqAXAxQC2Rg499JzQLu0nylzqZOt9aY/hwR3W5VplTE718cFGeeIuJEqXkqe9vn 0wZAERp2bUkn5bjILjD5a6WbaN40ggVG3wnMLRjz4URU65G0weoIMuRKIO3CRq2Klgpq6KfskFp WDIO2Dkd6KkDhziC9NgbRtwe+qcO5gL9GWmsWOtzjlA9pIQpXtoXKxXLM3bLWThx0nJtaBu6O8E g== X-Received: by 2002:a05:6808:6501:b0:479:e96e:65b0 with SMTP id 5614622812f47-482970b1562mr1996746b6e.10.1778601465103; Tue, 12 May 2026 08:57:45 -0700 (PDT) Received: from ?IPV6:2600:8803:e7e4:500:baa4:f7fb:528a:2457? ([2600:8803:e7e4:500:baa4:f7fb:528a:2457]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-435573e94edsm13047414fac.13.2026.05.12.08.57.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 May 2026 08:57:44 -0700 (PDT) Message-ID: Date: Tue, 12 May 2026 10:57:43 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] iio: mapping file for include-what-you-use tool To: Andy Shevchenko Cc: Joshua Crofts , jic23@kernel.org, nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260512073505.1310-1-joshua.crofts1@gmail.com> <4742ea18-f3df-46dd-aad4-18d1e5f03f7f@baylibre.com> Content-Language: en-US From: David Lechner In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/12/26 10:51 AM, Andy Shevchenko wrote: > On Tue, May 12, 2026 at 10:36:00AM -0500, David Lechner wrote: >> On 5/12/26 2:35 AM, Joshua Crofts wrote: >>> As promised, I'm sending my IWYU mapping file, based on Jonathan's >>> version with a few additional tweaks by me. >>> >>> Other than adding support for more assembly file business, I've also >>> experimented with individual symbol definition (see BIT() and GENMASK() >>> in the following file) - this is to prevent issues such as the tool >>> wanting you to include when you already have >>> in the source file (I agree, doing this symbol by >>> symbol is tedious, but BIT() and GENMASK() are symbols that especially >>> do this, and they're included in most, if not all drivers). >> >> TBH, I would favor rules that are easy for machines over rules that >> follow existing human conventions. Is there really anything terribly >> wrong with including both bits.h and bitops.h other than "convention"? > > But why? When one needs bitops APIs it includes BIT() and GENMASK() for bonus. > Same with (and especially) bitmap.h. The latter is rather a heavy header. > I do not see any point of having all three and even two out of the three > bits.h, bitops.h, bitmap.h. Also this is a type of unification that helps > scripting any further header reshuffling / cleanups / ... If we ever do > something with bits.h, let's do it on the files that really use only it. Because that is human thinking. :-) I don't particularly care what the end result is as long as we can automate it. It means one less thing I have to think about. > > So, all that being said, I prefer to follow guarantees and change them > if required once for all stakeholders, the mixing makes it harder to achieve. > Bonus is the compilation time (maybe negligible, though). >