public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH][next] clk: cdce925: Remove redundant assignment to variable 'rate'
@ 2024-02-16 14:01 Colin Ian King
  2024-02-22  5:36 ` Stephen Boyd
  0 siblings, 1 reply; 2+ messages in thread
From: Colin Ian King @ 2024-02-16 14:01 UTC (permalink / raw)
  To: Michael Turquette, Stephen Boyd, linux-clk; +Cc: kernel-janitors, linux-kernel

The variable 'rate' being assigned a value that is never read, the
assignment is redundant and can be removed.

Cleans up clang scan build warning:
drivers/clk/clk-cdce925.c:104:3: warning: Value stored to 'rate' is
never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
 drivers/clk/clk-cdce925.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
index b0122093c6ff..e48be7a6c0e2 100644
--- a/drivers/clk/clk-cdce925.c
+++ b/drivers/clk/clk-cdce925.c
@@ -101,7 +101,6 @@ static void cdce925_pll_find_rate(unsigned long rate,
 
 	if (rate <= parent_rate) {
 		/* Can always deliver parent_rate in bypass mode */
-		rate = parent_rate;
 		*n = 0;
 		*m = 0;
 	} else {
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH][next] clk: cdce925: Remove redundant assignment to variable 'rate'
  2024-02-16 14:01 [PATCH][next] clk: cdce925: Remove redundant assignment to variable 'rate' Colin Ian King
@ 2024-02-22  5:36 ` Stephen Boyd
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Boyd @ 2024-02-22  5:36 UTC (permalink / raw)
  To: Colin Ian King, Michael Turquette, linux-clk
  Cc: kernel-janitors, linux-kernel

Quoting Colin Ian King (2024-02-16 06:01:32)
> The variable 'rate' being assigned a value that is never read, the
> assignment is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> drivers/clk/clk-cdce925.c:104:3: warning: Value stored to 'rate' is
> never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---

Applied to clk-next

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-22  5:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-16 14:01 [PATCH][next] clk: cdce925: Remove redundant assignment to variable 'rate' Colin Ian King
2024-02-22  5:36 ` Stephen Boyd

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox