The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>,
	"Arthur Crépin Leblond" <arthur@marmottus.net>
Cc: Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Netdev <netdev@vger.kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/3] dt-bindings: net: wiznet,w5100: add link-gpios
Date: Mon, 10 Aug 2026 10:31:50 +0200	[thread overview]
Message-ID: <f2e4fcfc-0713-491c-9749-bc75b1169776@kernel.org> (raw)
In-Reply-To: <ed92fe3b-2fef-4343-8ef9-314e8753ce69@app.fastmail.com>

On 10/08/2026 10:25, Arnd Bergmann wrote:
> On Mon, Aug 10, 2026, at 10:21, Krzysztof Kozlowski wrote:
>> On 10/08/2026 10:12, Arthur Crépin Leblond wrote:
>>>
>>> We use this line to detect a link change but don't read its value in
>>> the interrupt handler, we read the i2c PHYCFGR register to get the
>>> link status.
>>
>> I know, but won't you have soon the same problem with active? Otherwise
>> are you going to keep polling for the active link, since it is not
>> reported through the main interrupt?
> 
> I don't see how we'd ever want to report 'active' state back to
> the kernel, this just means it's either receiving or transmitting,
> and the kernel already knows when a data transfer happened
> because it either started sending or it receives an interrupt for
> a received frame.

True, that was just an example so the author thinks about it instead of
just solving one problem now. For example neither speed nor duplex are
reported in the main interrupt and you might need to configure something
if they change.

Best regards,
Krzysztof

  reply	other threads:[~2026-08-10  8:31 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 14:59 [PATCH net-next v3 0/3] w5100: restore GPIO-based link detection Arthur Crépin Leblond
2026-08-06 15:00 ` [PATCH net-next v3 1/3] dt-bindings: net: wiznet,w5100: convert to DT schema Arthur Crépin Leblond
2026-08-10  7:40   ` Krzysztof Kozlowski
2026-08-06 15:00 ` [PATCH net-next v3 2/3] dt-bindings: net: wiznet,w5100: add link-gpios Arthur Crépin Leblond
2026-08-10  7:43   ` Krzysztof Kozlowski
2026-08-10  7:50     ` Arthur Crépin Leblond
2026-08-10  7:53     ` Arnd Bergmann
2026-08-10  7:59       ` Krzysztof Kozlowski
2026-08-10  8:12         ` Arthur Crépin Leblond
2026-08-10  8:21           ` Krzysztof Kozlowski
2026-08-10  8:25             ` Arnd Bergmann
2026-08-10  8:31               ` Krzysztof Kozlowski [this message]
2026-08-10 14:46                 ` Arthur Crépin Leblond
2026-08-10  7:55     ` Krzysztof Kozlowski
2026-08-06 15:00 ` [PATCH net-next v3 3/3] w5100: detect carrier state using link status bit Arthur Crépin Leblond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2e4fcfc-0713-491c-9749-bc75b1169776@kernel.org \
    --to=krzk@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=arnd@arndb.de \
    --cc=arthur@marmottus.net \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox