From: Dave Hansen <dave.hansen@intel.com>
To: Brian Mak <makb@juniper.net>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] x86/boot: Add option to append to the cmdline
Date: Wed, 1 Oct 2025 17:13:37 -0700 [thread overview]
Message-ID: <f2ed7b6a-46f5-4ef2-a0d8-703595a5ffee@intel.com> (raw)
In-Reply-To: <20251001230408.13137-1-makb@juniper.net>
On 10/1/25 16:04, Brian Mak wrote:
> To solve this limitation, we add CONFIG_CMDLINE_EXTEND, which is already
> available on several other architectures, to make the built-in command
> line append to the bootloader-provided command line.
I'd really rather not have another copy-and-paste of another
architecture's Kconfig bits into x86.
At the _very_ least, we'd get a boolean ARCH_HAS_CMDLIND_EXTEND which
would then expose an arch-independent CMDLINE_EXTEND option. Literally
duplicating Kconfig options just isn't scalable.
I also cringe every time I see code like this get added to arch/x86 that
really doesn't have anything to do with x86 and really only gets dumped
in to arch/ because there's never been a proper refactoring of all the
copy-and-pasted code.
In the end, refactoring Kconfig is dirt simple. Refactoring
builtin_cmdline[] into arch-independent code would be a lot harder.
next prev parent reply other threads:[~2025-10-02 0:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 23:04 [PATCH RESEND] x86/boot: Add option to append to the cmdline Brian Mak
2025-10-02 0:13 ` Dave Hansen [this message]
2025-10-02 17:30 ` Brian Mak
2025-10-02 20:33 ` Daniel Walker (danielwa)
-- strict thread matches above, loose matches on Subject: below --
2025-09-15 20:26 Brian Mak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2ed7b6a-46f5-4ef2-a0d8-703595a5ffee@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=makb@juniper.net \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox