public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Xin Li <xin@zytor.com>
To: Max Kellermann <max.kellermann@ionos.com>,
	hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch/x86/entry_fred: don't set up KVM IRQs if KVM is disabled
Date: Thu, 15 Feb 2024 10:23:33 -0800	[thread overview]
Message-ID: <f2f06960-86aa-4e79-afe6-c53ee7cbfabe@zytor.com> (raw)
In-Reply-To: <20240215133631.136538-1-max.kellermann@ionos.com>

On 2/15/2024 5:36 AM, Max Kellermann wrote:
> When KVM is disabled, the POSTED_INTR_* macros do not exist, and the
> build fails.
> 
> Fixes: 14619d912b65 ("x86/fred: FRED entry/exit and dispatch code")
> Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
> ---
>   arch/x86/entry/entry_fred.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/x86/entry/entry_fred.c b/arch/x86/entry/entry_fred.c
> index ac120cbdaaf2..660b7f7f9a79 100644
> --- a/arch/x86/entry/entry_fred.c
> +++ b/arch/x86/entry/entry_fred.c
> @@ -114,9 +114,11 @@ static idtentry_t sysvec_table[NR_SYSTEM_VECTORS] __ro_after_init = {
>   
>   	SYSVEC(IRQ_WORK_VECTOR,			irq_work),
>   
> +#if IS_ENABLED(CONFIG_KVM)
>   	SYSVEC(POSTED_INTR_VECTOR,		kvm_posted_intr_ipi),
>   	SYSVEC(POSTED_INTR_WAKEUP_VECTOR,	kvm_posted_intr_wakeup_ipi),
>   	SYSVEC(POSTED_INTR_NESTED_VECTOR,	kvm_posted_intr_nested_ipi),
> +#endif
>   };
>   
>   static bool fred_setup_done __initdata;

Hmm, we did test against !CONFIG_KVM.

The POSTED_INTR_* macros are under CONFIG_HAVE_KVM, which is 'selected'
under CONFIG_X86.

Can you please send me your kernel config file?

-- 
Thanks!
     Xin


  reply	other threads:[~2024-02-15 18:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-15 13:36 [PATCH] arch/x86/entry_fred: don't set up KVM IRQs if KVM is disabled Max Kellermann
2024-02-15 18:23 ` Xin Li [this message]
2024-02-15 19:30   ` Max Kellermann
2024-02-15 19:55 ` Sean Christopherson
2024-02-16  2:10   ` Xin Li
2024-02-16  6:31     ` Paolo Bonzini
2024-02-16 17:41       ` Xin Li
2024-02-16 17:47         ` Xin Li
2024-02-16 21:45       ` Thomas Gleixner
2024-02-16 23:00         ` Max Kellermann
2024-02-17  0:11           ` Thomas Gleixner
2024-02-17  9:52         ` Paolo Bonzini
2024-02-17 22:25           ` Thomas Gleixner
2024-02-16 21:46       ` Borislav Petkov
2024-02-16 22:29         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f2f06960-86aa-4e79-afe6-c53ee7cbfabe@zytor.com \
    --to=xin@zytor.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=max.kellermann@ionos.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox