From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com [209.85.161.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 114E71AC44D for ; Mon, 1 Dec 2025 21:31:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764624699; cv=none; b=erc8J/qjTD9j8KUMuWLF/oL3EZaLQgMnQLAGjLqjEmhK+cIrWUWeQ8UoOvGYLpK5Y3nW8GcizC61Xix7HWEAymyQ55Z7bDPeT7SzdCiTPFOMiXTMjpMcXz0GL/kDCE3NySjINClfUZ2AIvLjSW5pt7n+b3cjOvNhokr2BXKa0ok= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764624699; c=relaxed/simple; bh=XL2CB5sDiuTZ+OJZk+H9Xwof5J1Jcr14SFfLDHpMJKM=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=m5DWUXXzPBBGPm4gHBOyEyeX23ytIShNdmtc/yUxzfiJwGFxIWOXQTqXTPHDikOjHm8qnqEMEcaD5DpmA1EYiYP0qLu+Jaz91FDnjbebiLFUsV0gxEtZsQ2jg6fYFW7BSQwPbbbf59UHU0Y7gNnpEJH4zjJ025Y+mAc0TR7ddYw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=O2Hb4hPb; arc=none smtp.client-ip=209.85.161.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="O2Hb4hPb" Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-657490df6f3so1833222eaf.2 for ; Mon, 01 Dec 2025 13:31:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1764624697; x=1765229497; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=SNzFkX2JS6Qfs/iZwnjpRyB2He/h824sD+O3Ez2CnIc=; b=O2Hb4hPbVjBbS44Ylteafg6rWWBO3meDyHp9rhnFAhJTSkX3ZAuITeWBzp/6z8y8Bq PEDWJ27gbjORM1lzLk7z18jkT9lDSuD6sNXJLxnywTC5No3fMXuGCH10cwghO3RIcuug lnxXpXW/e0wAKgl62GHtk6FH+LfDSLDzad/pZCuWZxRvJPiXcktuxu9LOVBFoXote7VU ddmI8qvrtvYS/XXxS2BiOy8pAFaMazC9M0fV5qEQ4hUZFcOdbHBSZhNlmLe5VeSFX0SQ foLAOHP32Sb/CAIv4fujvmNjb3qp+VFayyCWX5pKS3cItTg6ZrqLI2gylAqP1CPxdPtM ai0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764624697; x=1765229497; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SNzFkX2JS6Qfs/iZwnjpRyB2He/h824sD+O3Ez2CnIc=; b=xEV6FiOrdY5s2sTlKGS2TZv8f8YS+NO5GsP4/2+cBV9s6QBAwGQ2cq3xC3kz9Et5Yf 8U3ws2bhD5fPo59cCbXZdSeXfeT/kkq+C+/utMP+vCJRzLrLsP4V+sOq8MxZEHxqQVZK 9+RpCfUnTV9RyNOYRb5nl/4f/6rsVBCQfapW+tFs2JawCfMptzEMDsiLTazwhT0K6hEa pMGlLYB4nexkeTeDFYLKjNjCflWxNKG7IhtAGkSWmOHclbWMT5ERSNPeuCCut7Zid/Ti 8xpncoXBDrkcs14dAO3aji5APGczifPGUA+ZVv6frMveTkB51tsTu3uVAuXq3v3mE8gg bTQQ== X-Forwarded-Encrypted: i=1; AJvYcCWufy8ZJ5YjXyidBJQ7U0n7AEZmz77D++L9EjcgLmGxnxvf4WS2pzsI/t4TPcqMNlGTiFkBRAwzClIxuKU=@vger.kernel.org X-Gm-Message-State: AOJu0Ywhe6MwhhmMsXxgTjDSbygl+Dqbsc+3QoZlVRLUw/wZsZjch4PE ggVgEUJAHeTiRb6oSsQPr49okbTVbODRhfn3OHKs0XlU9ysYMUDWBUu5tSJdE0fXy+s= X-Gm-Gg: ASbGnctx/i8EYzFN4PJnJzuIAtjUiUBiqwoNdUUJF/LPeRpsjxTa0yJvzqUAyGEH6cC Cx8R4w3htEQCoIMad0f1ZA5FIln9ZMbWzmvBCw/JiLshj4soinD8Q1zcRfSywLskw/eLVQ7BZuu IhBqLZMzcKx9g4odv2nEay5+JHpJFUxAXMRuf7HYjUFEgu0K1JZy64uyYvyoaFfmyG9xpwoMT8B 4PJhvTzhV6LxLQ/JamJX3RA3HD//9APh/OKlA0TpiIOjv+t6VkjleFtsfSRhmzBREFy4W57xytY EQa7p0V8O6zSAhCn96dLcPuxbbHnJRoPqBS/epQzTQJHQ2CMCIqi2ijvp4b3Spi8XtDLdoGHrPq tZT+PvJO98W+/oIWMccS+/amR9WcTp7zljz6YyjOnJm+ThFY6+pGEdqHUB5sKhkea24cn9fODGv PbdZv3Ug== X-Google-Smtp-Source: AGHT+IEmDsMI/DJCy7XHHMD1CgyVZQfVJ2d/2ww6SRt7GJRjSNWeRH540pBRJjo2YHm5xHO+vzhY2Q== X-Received: by 2002:a05:6808:c3ed:b0:44d:a44f:1e87 with SMTP id 5614622812f47-45112b3e815mr16516905b6e.40.1764624697010; Mon, 01 Dec 2025 13:31:37 -0800 (PST) Received: from [192.168.1.99] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4531708f448sm4306358b6e.12.2025.12.01.13.31.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 Dec 2025 13:31:36 -0800 (PST) Message-ID: Date: Mon, 1 Dec 2025 14:31:35 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [syzbot] [io-uring?] memory leak in io_submit_sqes (5) To: syzbot , io-uring@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <692dcb58.a70a0220.2ea503.00b5.GAE@google.com> Content-Language: en-US From: Jens Axboe In-Reply-To: <692dcb58.a70a0220.2ea503.00b5.GAE@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Let's try this again, seemed like a testing failure last time... #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master diff --git a/io_uring/poll.c b/io_uring/poll.c index b9681d0f9f13..0d5bb90d4743 100644 --- a/io_uring/poll.c +++ b/io_uring/poll.c @@ -936,12 +936,17 @@ int io_poll_remove(struct io_kiocb *req, unsigned int issue_flags) ret2 = io_poll_add(preq, issue_flags & ~IO_URING_F_UNLOCKED); /* successfully updated, don't complete poll request */ - if (!ret2 || ret2 == -EIOCBQUEUED) + if (ret2 == IOU_ISSUE_SKIP_COMPLETE) goto out; + /* request completed as part of the update, complete it */ + else if (ret2 == IOU_COMPLETE) + goto complete; } - req_set_fail(preq); io_req_set_res(preq, -ECANCELED, 0); +complete: + if (preq->cqe.res < 0) + req_set_fail(preq); preq->io_task_work.func = io_req_task_complete; io_req_task_work_add(preq); out: -- Jens Axboe